Fixes #24263 - Added managed content medium provider #7531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of monkey patching Redhat class, created a medium provider to be used in foreman.
|
Issues: #24263 |
iNecas
reviewed
Jul 17, 2018
| end | ||
|
|
||
| def medium_uri(path = "") | ||
| kickstart_repo = entity.try(:content_facet).try(:kickstart_repository) || entity.try(:kickstart_repository) |
There was a problem hiding this comment.
I wonder what happens when the kickstart repository is not set. Where is the mechanism that would fallback to the original Foreman's behavior?
There was a problem hiding this comment.
It's outside of a specific provider. The providers are chosen based on the result of #validate call.
lzap
approved these changes
Jul 26, 2018
|
Hello Katello devs I just merged the core part which will likely break your tests, this PR fixes it! @ShimShtein @iNecas @jlsherrill and perhaps @parthaa ... |
|
[test katello] |
jlsherrill
approved these changes
Jul 26, 2018
|
@ShimShtein++ @jlsherrill++ thanks folks! That was smooth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of monkey patching Redhat class, created a medium provider to be used in foreman.
This PR should be merged after theforeman/foreman#5244 is merged. It changes the way medium_uri is obtained for a host.