fixes #24305 - container image registry config #7543
Conversation
|
@ekohl - matching PR to puppet-katello |
thomasmckay
force-pushed
the
24305-registry-config
branch
from
f333211
to
b3521df
Compare
|
[test katello] |
| url = cfg[:url] | ||
| if SETTINGS[:katello][:container_image_registry] | ||
| cfg = SETTINGS[:katello][:container_image_registry] | ||
| url = cfg[:crane_url] |
There was a problem hiding this comment.
This implies it only works with crane and no other container registry. Is that correct?
There was a problem hiding this comment.
@ekohl - That's correct.
There was a problem hiding this comment.
If it only works with crane, you might as well name the name the section crane, right? Registry is singular so a user wouldn't expect to be able to use more than one anyway.
There was a problem hiding this comment.
@ekohl No, let's keep it as crane since that makes it very clear what service is being contacted. There is a chance there will be an alternative registry implementation in the coming months as well so this will help distinguish it. Thanks!
There was a problem hiding this comment.
I thought this had all been finalized on the related PR too. theforeman/puppet-katello#243 (comment)
There was a problem hiding this comment.
I'd like to know where it's going and get it right the first time. I would expect registries to behave in the same way so they can be used interchangeable but perhaps this is not the reality.
So currently the format is:
:container_image_registry:
:crane_url: ""
:ca_ca_cert_file: ""Now if another registry is added, how will this be configured?
:container_image_registry:
:registry_type: "crane" # or my_registry
:crane_url: ""
:ca_ca_cert_file: ""
:my_registry_type_url: ""
:my_registry_type_ca_cert_file: ""
thomasmckay
force-pushed
the
24305-registry-config
branch
from
b3521df
to
84f6784
Compare
|
@ekohl - Ready to merge? |
|
Perhaps it'd also be good to add this to katello.yaml.example. |
thomasmckay
force-pushed
the
24305-registry-config
branch
from
84f6784
to
74ba38b
Compare
|
@akofink - updated example |
theforeman/puppet-katello_devel#168
theforeman/puppet-katello#243
#7543