Fixes #24188 - Filter by OSTree on RH Repos #7545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #24188 |
akofink
reviewed
Jul 20, 2018
| debugRpm: 'name ~ debug rpm', | ||
| kickstart: 'name ~ kickstart', | ||
| ostree: 'name ~ ostree', | ||
| rpm: '(name ~ rpms) and (name !~ source rpm) and (name !~ debug rpm) and (content_type = yum)', |
There was a problem hiding this comment.
Shouldn't we remove (name ~ rpms) here?
There was a problem hiding this comment.
I would remove (name ~ rpms) and add (name !~ kickstart)
There was a problem hiding this comment.
oh wait, kickstart is a content type, yes remove this piece
| ostree: 'name ~ ostree', | ||
| rpm: '(name ~ rpms) and (name !~ source rpm) and (name !~ debug rpm) and (content_type = yum)', | ||
| sourceRpm: '(name ~ source rpm) and (content_type = yum)', | ||
| debugRpm: '(name ~ debug rpm) and (content_type = yum)', |
There was a problem hiding this comment.
So we don't have a content_type for source/debug rpms?
There was a problem hiding this comment.
The content_type is yum, just like rpms. I think this value comes from Pulp.
This commit corrects the 'scope search' parameter used by the "Filter by" dropdown on the RH Repos page to search OSTree and other content types.
|
@akofink @jlsherrill @waldenraines updated |
akofink
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit corrects the 'scope search' parameter
used by the "Filter by" dropdown on the RH Repos page
to search OSTree and other content types.