Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24395 - Add missing permissions to host subscriptions #7570

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Fixes #24395 - Add missing permissions to host subscriptions #7570

merged 1 commit into from
Jul 26, 2018

Conversation

timkaechele
Copy link
Contributor

  • Adds the action permissions 'destroy' and
    'available_release_versions' to the action_permissions
  • Adds a else block to catch missing permissions

@theforeman-bot
Copy link

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

1 similar comment
@theforeman-bot
Copy link

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@theforeman-bot
Copy link

Issues: #24395

@timogoebel
Copy link
Contributor

ok to test

Copy link

@dgoetz dgoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it successfully with Katello 3.4.5 and 3.6.0.

Copy link
Contributor

@timogoebel timogoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

- Adds the action permissions 'destroy' and
  'available_release_versions' to the action_permissions
- Adds a else block to catch missing permissions
Copy link
Member

@jlsherrill jlsherrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timkaechele

@jlsherrill jlsherrill merged commit 5c41cef into Katello:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants