Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #24168 - registry name examples #7597

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

thomasmckay
Copy link
Member

New PR since existing could not be reopened (#7564)

@akofink @Rohoover

lifecycle environment library

@theforeman-bot
Copy link

Issues: #24168

Copy link
Member

@akofink akofink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info is A+ quality. :) Maybe it's too much to show on this page from a UX perspective, but it's certainly very helpful. ACK from me!

@akofink
Copy link
Member

akofink commented Aug 6, 2018

I did notice that edit icon is pushed off to the far right of the screen. Probably considered bad UX.

@Rohoover
Copy link

Rohoover commented Aug 6, 2018

Considering the technical limitations of this page, I think this is an improvement. Thanks!

@akofink
Copy link
Member

akofink commented Aug 6, 2018

eslint failure seems related.

@thomasmckay thomasmckay merged commit 069fe18 into Katello:master Aug 6, 2018
@thomasmckay thomasmckay deleted the 24168-help-pattern branch August 6, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants