Fixes #24549 - Add rendering extension tests #7602
Conversation
|
Issues: #24549 |
lib/katello/engine.rb
Outdated
| if Katello.with_remote_execution? | ||
| ::ForemanRemoteExecution::Renderer::Scope::Input.send :include, Katello::Concerns::InputTemplateScopeExtensions | ||
| end | ||
| ::Foreman::Renderer::Scope::Base.send :include, Katello::Concerns::InputTemplateScopeExtensions |
There was a problem hiding this comment.
Should this be available for provisoning templates and partitions tables as well?
If so, please also rename the concern to BaseTemplateScopr extensions.
Better would be to explicity include this for all the template types that need the errata macro. Bear in mind that we also habe report templates now that are not associated to a host.
There was a problem hiding this comment.
The goal was to expand it to work with all templates yes, (it was largely to make it easier to test, and there's not necessarily a reason to restrict it to just REX templates).
Will rename it.
| end | ||
|
|
||
| def test_errata | ||
| source = Foreman::Renderer::Source::String.new( |
There was a problem hiding this comment.
Are tests failing due to a missing include for this?
There was a problem hiding this comment.
I think so, lets try this :)
jlsherrill
force-pushed
the
24549
branch
2 times, most recently
from
13a5107
to
3b04b04
Compare
and fix a few issues with those extensions. The errata id helper did not take permissions into account, the kickstart_attributes method was not using the new medium provider and thus would not work. This also moves the errata helper to the base input scope instead of on a REX class for easier testing.
and fix a few issues with those extensions. The
errata id helper did not take permissions into account,
the kickstart_attributes method was not using the new
medium provider and thus would not work. This also
moves the errata helper to the base input scope instead
of on a REX class for easier testing.