Fixes #24751 - Missing reset_column_information from rails_5.2 branch #7663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #24751 |
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
theforeman-bot
added
Waiting on contributor
Needs testing
Not yet reviewed
and removed
Waiting on contributor
labels
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
ik5
changed the title
tbrisker
requested changes
Aug 30, 2018
| @@ -60,6 +60,7 @@ def down | |||
| add_foreign_key "katello_subscription_products", "katello_products", | |||
| :name => "katello_subscription_products_product_id_fk", :column => "product_id" | |||
|
|
|||
| FakeSubscription.reset_column_information | |||
There was a problem hiding this comment.
This should also be in the up migration
There was a problem hiding this comment.
opss you are right, fixed that, sorry
tbrisker
approved these changes
Aug 30, 2018
ehelms
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.