Fixes #24429 - Module stream host bulk actions #7736

johnpmitsch · 2018-10-05T17:02:28Z

This adds both bulk content host and host collection actions to manage module streams

theforeman-bot · 2018-10-05T17:02:41Z

parthaa · 2018-10-05T17:28:37Z

...pts/bastion_katello/content-hosts/bulk/content-hosts-bulk-module-streams-modal.controller.js

+          { action: 'install', description: translate("Install")},
+          { action: 'update', description: translate("Update")},
+          { action: 'remove', description: translate("Remove")}
+        ];


should we have an angular service for DRYing this up?

yes, was planning on that

app/views/katello/api/v2/hosts_bulk_actions/module_streams.json.rabl

johnpmitsch · 2018-10-09T18:34:01Z

[test katello]

johnpmitsch · 2018-10-10T13:32:12Z

Here is an example of the host collections workflow. Bulk content host actions is very similar, just done from the content host page.

parthaa · 2018-10-10T14:59:11Z

Code changes LGTM. I was originally thinking if some of the stuff in views/content-host-bulk-module-streams-modal.html could be DRY'ed up, but I am hesitant to suggest that now considering content hosts module streams page will change once we get information from subman on enabled repositories.

johnpmitsch · 2018-10-10T15:40:10Z

[test katello]

jlsherrill · 2018-10-10T17:03:01Z

app/controllers/katello/api/v2/hosts_bulk_actions_controller.rb

+      options = {}
+      options[:group] = [:name, :stream]
+      options[:resource_class] = Katello::ModuleStream
+      host_module_streams = Katello::ModuleStream.available_for_hosts(@hosts)


how does @hosts get set here?

oh find_editable_hosts is set to :except =>
nevermind :)

jlsherrill

Approved from a code perspective. haven't' tested though

parthaa · 2018-10-10T21:01:28Z

app/controllers/katello/remote_execution_controller.rb

-        end
+        find_bulk_hosts('edit_hosts',
+          included: {
+            ids: params[:host_ids],


Found a bug. It expects host_ids to be an array like :host_ids =>[1,2,3], while what gets sent to remote command controller is something like :host_ids =>"1,2,3" so need to change this to params[:host_ids].try(:split, ',')

may be do something like params[:host_ids].is_a?(Array) ? params[:host_ids]: params[:host_ids].try(:split, ',')

@jlsherrill would you think something like this might be better in Concerns::Api::V2::BulkHostsExtensions

no, the browser should be sending an array IMO

hmm too many places to fix that then imo.

jlsherrill · 2018-10-10T21:12:40Z

Ah, if this is what the rex actions are doing, then I guess I'm okay with splitting it in the rex controller

…

On Wed, Oct 10, 2018, 5:07 PM Partha Aji ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/controllers/katello/remote_execution_controller.rb <#7736 (comment)>: > @@ -28,11 +30,13 @@ def prepare_composer end def hosts - if params[:scoped_search].present? - params[:scoped_search] - else - ::Host.where(:id => params[:host_ids].try(:split, ',')) - end + find_bulk_hosts('edit_hosts', + included: { + ids: params[:host_ids], hmm too many places to fix that then imo. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7736 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYHRVPOIZHa3-4t0vSn0BkDFRPGqRTJks5ujmGlgaJpZM4XKl8z> .

omkarkhatavkar · 2018-10-11T12:52:42Z

@johnpmitsch Any need of this Remove Button?

omkarkhatavkar · 2018-10-11T15:03:31Z

module stream links are from Module Stream Management -> takes to blank page everytime, just remove that 'and host' from search string

johnpmitsch · 2018-10-11T15:26:03Z

@parthaa @omkarkhatavkar @jlsherrill all issues have been addressed in a new commit. I'm currently setting up my environment to test multiple content hosts

parthaa · 2018-10-11T19:41:25Z

@johnpmitsch looks good. wfm.
ack

jlsherrill

ACK

omkarkhatavkar · 2018-10-12T13:24:28Z

@johnpmitsch: Work Nicely

Test Scenarios:

Verify the UI for host Collection Module Stream. -- Passed
Module actions enable, install, disable, remove for multiple hosts and host collection. -- Passed
Running same actions from rerun option. -- Passed
Running Custom Module Action on the host/hosts working fine. -- Passed

omkarkhatavkar · 2018-10-22T07:36:36Z

https://projects.theforeman.org/issues/25258 raised for running module stream actions on each host collections not all hosts.

omkarkhatavkar · 2018-10-22T07:36:57Z

https://projects.theforeman.org/issues/25258 raised for running module stream actions on each host collections not all hosts.

theforeman-bot added Needs testing Not yet reviewed labels Oct 5, 2018

johnpmitsch changed the title ~~[WIP] Fixes #24429 module stream hosts~~ [WIP] Fixes #24429 - Module stream host bulk actions Oct 5, 2018

johnpmitsch force-pushed the 24429_module_stream_hosts branch from 476cfe0 to 161e45d Compare October 5, 2018 17:18

parthaa reviewed Oct 5, 2018

View reviewed changes

johnpmitsch force-pushed the 24429_module_stream_hosts branch from 5c53f8d to 6ec0540 Compare October 5, 2018 19:32

John Mitsch added 5 commits October 9, 2018 13:26

Fixes #24429 - module stream bulk host actions

92f99d0

Fixes #24429 - Updated for new templates

51d0554

Refs #24429 - added service

d72e446

Fixes #24429 - moving to bulk hosts

9423372

Fixes #24429 - updated include

802dcb1

johnpmitsch force-pushed the 24429_module_stream_hosts branch from eacb6f5 to 802dcb1 Compare October 9, 2018 14:12

John Mitsch added 2 commits October 9, 2018 17:15

Fixes #24429 - UI uses bulk host actions

1248518

Fixes #24429 - fix bulk actions

dbbe532

johnpmitsch force-pushed the 24429_module_stream_hosts branch from f57d911 to dbbe532 Compare October 9, 2018 18:26

johnpmitsch commented Oct 9, 2018

View reviewed changes

app/views/katello/api/v2/hosts_bulk_actions/module_streams.json.rabl Outdated Show resolved Hide resolved

johnpmitsch changed the title ~~[WIP] Fixes #24429 - Module stream host bulk actions~~ Fixes #24429 - Module stream host bulk actions Oct 9, 2018

johnpmitsch force-pushed the 24429_module_stream_hosts branch 2 times, most recently from 1d7ff12 to 4337eb4 Compare October 9, 2018 23:42

Fixes #24429 - re-use template

f784c98

johnpmitsch force-pushed the 24429_module_stream_hosts branch from 4337eb4 to f784c98 Compare October 10, 2018 13:16

jlsherrill reviewed Oct 10, 2018

View reviewed changes

jlsherrill approved these changes Oct 10, 2018

View reviewed changes

parthaa reviewed Oct 10, 2018

View reviewed changes

Fixes #24429 - Removed cancel button, updated link, updated rex

7e51248

parthaa approved these changes Oct 11, 2018

View reviewed changes

jlsherrill approved these changes Oct 11, 2018

View reviewed changes

johnpmitsch merged commit 322cd49 into Katello:master Oct 11, 2018

johnpmitsch deleted the 24429_module_stream_hosts branch October 11, 2018 20:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #24429 - Module stream host bulk actions #7736

Fixes #24429 - Module stream host bulk actions #7736

johnpmitsch commented Oct 5, 2018 •

edited

Loading

theforeman-bot commented Oct 5, 2018

parthaa Oct 5, 2018

johnpmitsch Oct 5, 2018

johnpmitsch commented Oct 9, 2018

johnpmitsch commented Oct 10, 2018

parthaa commented Oct 10, 2018

johnpmitsch commented Oct 10, 2018

jlsherrill Oct 10, 2018

jlsherrill Oct 10, 2018

jlsherrill left a comment

parthaa Oct 10, 2018

parthaa Oct 10, 2018

parthaa Oct 10, 2018

jlsherrill Oct 10, 2018

parthaa Oct 10, 2018

jlsherrill commented Oct 10, 2018 via email

omkarkhatavkar commented Oct 11, 2018

omkarkhatavkar commented Oct 11, 2018

johnpmitsch commented Oct 11, 2018

parthaa commented Oct 11, 2018

jlsherrill left a comment

omkarkhatavkar commented Oct 12, 2018

omkarkhatavkar commented Oct 22, 2018

omkarkhatavkar commented Oct 22, 2018

Fixes #24429 - Module stream host bulk actions #7736

Fixes #24429 - Module stream host bulk actions #7736

Conversation

johnpmitsch commented Oct 5, 2018 • edited Loading

theforeman-bot commented Oct 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnpmitsch commented Oct 9, 2018

johnpmitsch commented Oct 10, 2018

parthaa commented Oct 10, 2018

johnpmitsch commented Oct 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jlsherrill left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jlsherrill commented Oct 10, 2018 via email

omkarkhatavkar commented Oct 11, 2018

omkarkhatavkar commented Oct 11, 2018

johnpmitsch commented Oct 11, 2018

parthaa commented Oct 11, 2018

jlsherrill left a comment

Choose a reason for hiding this comment

omkarkhatavkar commented Oct 12, 2018

omkarkhatavkar commented Oct 22, 2018

omkarkhatavkar commented Oct 22, 2018

johnpmitsch commented Oct 5, 2018 •

edited

Loading