Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25541 - Trigger singleton actions in post init hook #7848

Merged
merged 5 commits into from Dec 3, 2018
Merged

Fixes #25541 - Trigger singleton actions in post init hook #7848

merged 5 commits into from Dec 3, 2018

Conversation

adamruzicka
Copy link
Member

@adamruzicka adamruzicka commented Nov 23, 2018 •
edited

@theforeman-bot
Copy link

Issues: #25541

iNecas
iNecas reviewed Nov 23, 2018
View reviewed changes
lib/katello/engine.rb Outdated Show resolved Hide resolved
@iNecas
Copy link
Member

iNecas commented Nov 23, 2018

Tested and I can confirm this fixes the issue. One suggestion regrading removing the rake check + perhaps renaming the post_init (see the Dynflow PR)

@jlsherrill
Copy link
Member

looks good to me, i think we'll need a dynflow release for the tests to run

@adamruzicka
Copy link
Member Author

[test katello]

iNecas
iNecas approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@iNecas iNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything should be ready now

@jlsherrill jlsherrill merged commit c23ae22 into Katello:master Dec 3, 2018
@adamruzicka adamruzicka deleted the fix/25541-singletons branch December 6, 2018 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNecas iNecas iNecas approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
4 participants
@adamruzicka @theforeman-bot @iNecas @jlsherrill