fixes #25518 - fix invalid repos in 3.10 upgrade

[stbenjam]

To test this, you'll need to createa repo that has the bogus data that could've been created in older Katellos (prior to 3.9). To do that, go ahead and modify one of your existing repos and force set the username or password, but not both, like this:

$ rake console
> repo = Katello::RootRepository.last # or the repo you created
> repo.upstream_username = 'potato'
> repo.save!(validate: false)
> ^D
$ rake katello:upgrades:3.10:clear_invalid_repo_credentials

And notice the repo has the username unset and pulp is refreshed upon running the rake task.

[theforeman-bot]

Issues: #25518

[beav]

@stbenjam do you have to add anything to get the task to run during the upgrade? I haven't written an upgrade task since theforeman/foreman#5780 was merged so I'm not sure what the new procedure is.

[beav]

code looks good, testing now

[sjha4]

To run this during upgrade, you can add it to db/seeds.d/111-upgrade_tasks.rb

[beav]

test was successful. I created one of each debian, ostree, file, yum, docker and ran through the steps to corrupt the info. I then ran the rake task and it worked.

After the new task is added to db/seeds.d/111-upgrade_tasks.rb, ack from me!

[beav]

🐰