Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25695 - finish migration to concurrent-ruby-1.1 #7889

Merged
merged 2 commits into from Jan 10, 2019
Merged

Fixes #25695 - finish migration to concurrent-ruby-1.1 #7889

merged 2 commits into from Jan 10, 2019

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Dec 14, 2018

Remove the backward compatibility with concurrent-ruby-1.0

To be merged once dynflow 1.2 is released.

@theforeman-bot
Copy link

Issues: #25696

iNecas
iNecas commented Dec 14, 2018
View reviewed changes
katello.gemspec Outdated
@@ -29,7 +29,7 @@ Gem::Specification.new do |gem|

gem.add_dependency "rabl"
gem.add_dependency "foreman-tasks", "~> 0.13", ">= 0.14.1"
gem.add_dependency "dynflow", ">= 1.1.3"
gem.add_dependency "dynflow", ">= 1.2.0.pre1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be changed to >= 1.2.0 once dynflow-1.2.0 is out

@Katello Katello deleted a comment from theforeman-bot Dec 14, 2018
@iNecas
Copy link
Member Author

iNecas commented Dec 17, 2018

Test were failing, probably because I've forgot to push the dynflow pre-relesase to rubygems, trying again

[test katello]

@iNecas
Copy link
Member Author

iNecas commented Dec 19, 2018

I suppose this is a known error, and not related to the actual change, right?:

Error:

Katello::DockerMetaTagTest#test_import_meta_tags:

NoMethodError: undefined method `schema2' for nil:NilClass

    /var/lib/workspace/workspace/katello-pr-test/test/models/docker_meta_tag_test.rb:58:in `test_import_meta_tags'

bin/rails test /var/lib/workspace/workspace/katello-pr-test/test/models/docker_meta_tag_test.rb:35

@sjha4
Copy link
Member

sjha4 commented Dec 21, 2018

[test katello]

@iNecas iNecas mentioned this pull request Jan 2, 2019
Merged
@iNecas iNecas changed the title DNM: Fixes #25695 - finish migration to concurrent-ruby-1.1 Fixes #25695 - finish migration to concurrent-ruby-1.1 Jan 3, 2019
@iNecas
Copy link
Member Author

iNecas commented Jan 3, 2019

Dynlfow 1.2.0 has been released, so this change is no longer DNM

@ekohl
Copy link
Member

ekohl commented Jan 10, 2019

This resolves an issue in the nightly pipeline so consider this urgent :)

@jturel jturel self-assigned this Jan 10, 2019
@jturel
Copy link
Member

jturel commented Jan 10, 2019

[test katello]

running once more since some time has elapsed

jturel
jturel approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@jturel jturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me APJ

@jturel jturel merged commit dcdfec5 into Katello:master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturel jturel jturel approved these changes

Assignees

@jturel jturel

Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
5 participants
@iNecas @theforeman-bot @sjha4 @ekohl @jturel