Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #25667 - Fix saving nil to non-null column in repository #7897

Merged
merged 1 commit into from Dec 18, 2018
Merged

Refs #25667 - Fix saving nil to non-null column in repository #7897

merged 1 commit into from Dec 18, 2018

Conversation

johnpmitsch
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link

Issues: #25667

@johnpmitsch
Copy link
Contributor Author

Original commit is here 768446a#diff-f4739120764d6b2cb928caa6694c2a48R113

@parthaa
Copy link
Contributor

parthaa commented Dec 17, 2018

@johnpmitsch can you fix this test 768446a#diff-531c6bcdc5fc6f9f27014ab88263523aR16

instead of refute unprotected verify that the value returned by unprotected is false

@johnpmitsch
Copy link
Contributor Author

@parthaa updated

@johnpmitsch johnpmitsch merged commit 269d516 into Katello:master Dec 18, 2018
@johnpmitsch johnpmitsch deleted the 25667_small_fix branch December 18, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthaa parthaa parthaa approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
3 participants
@johnpmitsch @theforeman-bot @parthaa