Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #27229 - add message attribute to ping api #8196

Merged
merged 1 commit into from Jul 8, 2019

Conversation

amirfefer
Copy link
Contributor

@amirfefer amirfefer commented Jul 3, 2019

Related to #8039

ping API call doesn't return messages, so

Katello::Ping.ping[:services]

returns:

{:pulp=>{:status=>"FAIL", :message=>"Not all necessary pulp workers running at https://centos7-devel.tlv-fedora25.example.com/pulp/api/v2/."},
 :pulp_auth=>{:status=>"FAIL", :message=>"Skipped pulp_auth check after failed pulp check"}, 
:candlepin=>{:status=>"ok", :duration_ms=>"56"},
 :candlepin_auth=>{:status=>"ok", :duration_ms=>"26"}, 
:foreman_tasks=>{:status=>"ok", :duration_ms=>"18373"}}

while the api (/api/ping) returns:

  {"status":"FAIL","services":{"pulp":{"status":"FAIL"},"pulp_auth":{"status":"FAIL"},
"candlepin":{"status":"ok","duration_ms":"19"},
"candlepin_auth":{"status":"ok","duration_ms":"14"},
"foreman_tasks":{"status":"FAIL"}}}

@theforeman-bot
Copy link

Issues: #27229

@waldenraines
Copy link
Contributor

@jlsherrill any reason we shouldn't do this?

@jlsherrill
Copy link
Member

nope, thanks @amirfefer !

@jlsherrill jlsherrill merged commit 37c5203 into Katello:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants