Fixes #27524 - fix docker cv publishing

[ianballou]

To reproduce issue:

1. Create a custom docker repo with tags (fedora/ssh perhaps)
2. Sync it
3. Add it to a content view
4. Try to publish new version
5. It will fail

To test this patch:

1. Try the above steps
2. Check that there are no errors
3. Check that docker tags were indeed copied

[theforeman-bot]

Issues: #27524

[theforeman-bot]

There were the following issues with the commit message:

• b5ffedf must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

---

This message was auto-generated by Foreman's prprocessor

[theforeman-bot]

@ianballou, this pull request is currently not mergeable. Please rebase against the master branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream master

---

This message was auto-generated by Foreman's prprocessor

[jlsherrill]

lets not add another docker repo to fixtures. Lets try to adapt one that already exists if what we have isn't sufficient.

[jlsherrill]

I'm not sure this test actually reproduces the problem? I think you'd have to then create some content_view repo as well, and then index, passing in the source repo. Although there'd be nothing inthe content view repo. Maybe you could copy units over to the cv repo prior

[ianballou]

Ok, I'll bolster this a bit

[ianballou]

I've updated the test.

[ianballou]

Looks like I need to re record some VCRs before getting all the tests to pass.

[chris1984]

Works :)

Before patch:

2019-08-08T13:56:44 [E|bac|] PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "index_katello_docker_tags_on_pulp_id"
13:56:44 rails.1   |  | DETAIL:  Key (pulp_id)=(5b3b0767-4e0b-4029-b7c7-da1a618aade7) already exists.
13:56:44 rails.1   |  | : insert into katello_docker_tags (repository_id, pulp_id, name,docker_taggable_id,docker_taggable_type)
13:56:44 rails.1   |  |                     select 12 as repository_id, pulp_id, name,docker_taggable_id,docker_taggable_type from katello_docker_tags
13:56:44 rails.1   |  |                     where repository_id = 11 and pulp_id not in (select pulp_id
13:56:44 rails.1   |  |                     from katello_docker_tags where repository_id = 12) (ActiveRecord::RecordNotUnique)

https://nimb.ws/RlaHdL

After patch:

https://nimb.ws/w5Jx2y

[ianballou]

rebased and now I'm getting some Pulp3 Ansible errors, hm...

[sjha4]

[test katello]

[jlsherrill]

we can't rely on a specific count, as the next person that runs the test in live mode may get a different result. Something like

assert @repo.docker_tags.count > 0
assert_equal @repo.docker_tags.count, @repo_copy.docker_tags.count

should be sufficient. Also i think this test needs to be re-recorded after rebasing against master to get my vcr fixes that avoid duplicate recordings

[ianballou]

Rebased and test fixed

[jlsherrill]

Thanks @ianballou !!