Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #27795 - properly remove uneeded repos from FPC #8333

Merged
merged 1 commit into from Sep 9, 2019

Conversation

jlsherrill
Copy link
Member

No description provided.

@theforeman-bot
Copy link

Issues: #27795

@@ -58,7 +58,7 @@ def current_repositories_data(environment = nil, content_view = nil)
end

def orphaned_repos
@smart_proxy.pulp_repositories.map { |x| x["id"] } - current_repositories.map { |x| x.pulp_id }
@smart_proxy.pulp_repositories.map { |x| x["id"] } - repos_available_to_capsule.map { |x| x.pulp_id }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current_repositories returns 'repositories that are on the capsule that should be on the capsule'. While 'repos_available_to_capsule' are repos that should be on the capsule regardless of whether they are at the moment or not

@jlsherrill
Copy link
Member Author

[test katello]

Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack..Before the various refactorings around this, we were looking at available repos.. 👍

@jlsherrill jlsherrill merged commit 0771fe4 into Katello:master Sep 9, 2019
@jlsherrill jlsherrill deleted the 27795 branch September 9, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants