860952 - do not call with_indifferent_access on Array #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created new function array_with_indifferent_access and value on line 384 passed to this function. Additionaly all code in this module which do the same, flip to calling this function, which result in shorter code.
|
This looks good to me. ACK |
xsuchy
added a commit
that referenced
this pull request
Oct 12, 2012
860952 - do not call with_indifferent_access on Array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created new function
array_with_indifferent_access
and value on line 384 passed to this function.
Additionaly all code in this module which do the same, flip to calling
this function, which result in shorter code.
I will be honest here - I did not see passed test, because Dmitri broke the same test in different part of code, but the test succesfully passed point where it previously fails, so it should fix this problem.