-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #28049 - Index yum repo w/o errata refactoring w/ Pulp 3 #8412
Fixes #28049 - Index yum repo w/o errata refactoring w/ Pulp 3 #8412
Conversation
Issues: #28049 |
d4fd68c
to
071c676
Compare
@ianballou : Did you hit this: http://pastebin.test.redhat.com/811594 ? |
@sjha4 yeah, looks like I'll need to update the bindings again. |
Tested sync and indexing after modifying binding gem code a little. Able to index packages,errata modules etc.. 👍 |
oh yeah @sjha4 I see that too, I'll have to check why |
071c676
to
3b525cf
Compare
So using this https://fedorapeople.org/groups/katello/fakerepos/zoo repo, when syncing errata, the associated packages are not indexed correctly. I believe only the first is getting indexed. |
3b525cf
to
9280ac3
Compare
@sjha4 yeah I see that too. Looks like it doesn't happen for all repos, since more than one package per errata was indexed for this larger zoo repo https://jlsherrill.fedorapeople.org/fake-repos/needed-errata/ |
9280ac3
to
be579b8
Compare
@sjha4 I fixed the missing packages issue. |
be579b8
to
ca59c22
Compare
I've made a work-around for the issue where individual package pages were failing to load. There's still an issue where the package 'provides' and 'requires' data comes back in a weird format, so I'm stubbing those for now. |
459cfba
to
36da611
Compare
I'm not seeing any kickstart distribution information being indexed, is that known/tracked? |
The distribution data worked for me with the CentOS 7 repo, what repo did
you sync? Also I have a distribution test, is that the information you're
talking about?
… |
@jlsherrill I'll give that a test, I expected that data to populate |
as we discussed on irc, it seemed to be a pulp bug, so i've filed that |
fixed the indexing of file and build information for packages. |
37cc0b0
to
46fec9e
Compare
Now package dependencies should be listed ok. The approach I took to generate the strings should be revisited. Hopefully at some point the data will be returned from Pulp as a hash with the correct keys rather than an array where we need to guess from the indices. |
7ff238a
to
c48eb8a
Compare
I've refactored some of the pulp3 tests to give them a pulp3 module. There were issues with class naming for RpmTest since there wasn't a pulp3 module but it shared a name with the pulp2 tests. |
3b68e1c
to
b2bd157
Compare
@ianballou : What version of the pulp_rpm_client are you on? I believe I am on pulp_rpm_client-3.0.0b71571331815 which doesn't have the file lib/pulp_rpm_client/models/rpm_update_record.rb file. The validations are in the update_record.rb file which makes me think I am on a newer version. |
@sjha4 I'm on the same version as master at the moment. |
Findings based on testing with 3.0.0b8.dev01573228480:
Pulp2: |
b2bd157
to
5924fd5
Compare
@ianballou : Seeing a routing error now: nvm if you don't see this cause my confidence in my pulp3 box is not too high..Could be unrelated.. |
@sjha4 yeah I think it has to do with our boxes having slightly different versions of the pulp code. It'll be easier to confirm when we can bring up a new clean pulp box again |
5924fd5
to
005c21e
Compare
d1c8c86
to
1bfabe3
Compare
cef9926
to
8a4636f
Compare
8a4636f
to
940b277
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APJ!
This PR enables yum content indexing with Pulp 3. Limitations:
TESTING:
Try to sync various repositories and view their errata, distribution information, packages, and appstream modules. Note the limitations above. Don't try to sync the RHEL 7 Server RPMs repo unless you have more than 12 GB ram.
For now, remove any empty string checks in this file:
The empty string checks will look like this:
We're hoping to merge this sooner rather than later. Since it's Pulp 3 and doesn't affect normal Katello users, we may merge with some of the following TODOs unchecked.
TODO:
erratum_test.rb
(Pulp 3 having issues withfile:///var/www/test_repos/zoo/
repo)Add Package Group support (in this PR or another?)