Fixes #28189 - Refresh repo when needed #8415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #28189 |
|
To test this
Now check out the PR
|
|
[test katello] |
|
@parthaa is there a test case where the |
https://github.com/Katello/katello/pull/8415/files#diff-9a8be58a012da76042ea5e21ad94e40aR160 I test if refresh_if_needed does not call refresh |
sjha4
reviewed
Nov 5, 2019
jlsherrill
reviewed
Nov 6, 2019
| @@ -199,6 +201,10 @@ def proxy_host_importer_value | |||
| root.ignore_global_proxy ? "" : nil | |||
| end | |||
|
|
|||
| def refresh_if_needed | |||
| refresh if needs_importer_updates? || needs_distributor_updates? | |||
| end | |||
There was a problem hiding this comment.
this is the same logic as mirror_needs_updates? maybe we could combine those into one method?
When a manifest refresh is triggered all the RH repos update their distributors and importers, even if those repos did not change. This commit makes a repo update its importers and distributors only if needed.
parthaa
force-pushed
the
refreshIfNeeded
branch
from
b90d55e
to
07b8cf6
Compare
|
[test katello] |
2 similar comments
|
[test katello] |
|
[test katello] |
sjha4
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
ACK based on the below testing:
- On master, manifest refresh causes pulp repo refresh on all enabled repos.
- On branch, manifest refresh does not invoke pulp tasks for enabled repos when not needed
- On branch, manifest refresh does invoke pulp tasks for enabled repos when needed
jturel
pushed a commit
to jturel/katello
that referenced
this pull request
Nov 20, 2019
* Fixes #28189 - Refresh repo when needed When a manifest refresh is triggered all the RH repos update their distributors and importers, even if those repos did not change. This commit makes a repo update its importers and distributors only if needed. (cherry picked from commit 1237135)
jturel
pushed a commit
to jturel/katello
that referenced
this pull request
Nov 20, 2019
* Fixes #28189 - Refresh repo when needed When a manifest refresh is triggered all the RH repos update their distributors and importers, even if those repos did not change. This commit makes a repo update its importers and distributors only if needed. (cherry picked from commit 1237135)
jturel
pushed a commit
that referenced
this pull request
Nov 25, 2019
* Fixes #28189 - Refresh repo when needed When a manifest refresh is triggered all the RH repos update their distributors and importers, even if those repos did not change. This commit makes a repo update its importers and distributors only if needed. (cherry picked from commit 1237135)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a manifest refresh is triggered all the RH repos update their
distributors and importers, even if those repos did not change. This
commit makes a repo update its importers and distributors only if
needed.