Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip our repo #849

Merged
merged 1 commit into from
Oct 16, 2012
Merged

Do not skip our repo #849

merged 1 commit into from
Oct 16, 2012

Conversation

xsuchy
Copy link
Contributor

@xsuchy xsuchy commented Oct 15, 2012

In deep history our repos were unstable and this had sense.
But our repositories are now rock stable and this does not have really sense.
Therefore I suggest to remove it.

In deep history our repos were unstable and this had sense.
But our repositories are now rock stable and this does not have really sense.
Thefore I suggest to remove it.
@ozzak
Copy link

ozzak commented Oct 15, 2012

Unit tests green but unmigrate unsuccessful

==  CreateCustomInfo: reverting ===============================================
-- remove_index(:custom_info, {:name=>"index_custom_info_on_inf_type_and_inf_id_and_kn_and_v"})
rake aborted!
An error has occurred, this and all later migrations canceled:

Index name 'index_custom_info_on_inf_type_and_inf_id_and_kn_and_v' on table 'custom_info' does not exist

Tasks: TOP => db:migrate
(See full trace by running task with --trace)

https://gist.github.com/3891573

@lzap
Copy link
Contributor

lzap commented Oct 15, 2012

There was an issue with my test script, I did not clear database before test run. I have fixed this and resubmitted this issue. There should be no migration issues anymore.

@ozzak
Copy link

ozzak commented Oct 15, 2012

All unit tests are green :-)

"Boy, life takes a long time to live."
        -- Steven Wright

https://gist.github.com/3891755

@lzap
Copy link
Contributor

lzap commented Oct 15, 2012

Yeah we don't need this anymore, with Koji our repos are stable now. ACK

xsuchy added a commit that referenced this pull request Oct 16, 2012
@xsuchy xsuchy merged commit 5c113ae into Katello:master Oct 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants