Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

866323 - do not print binary files to log #850

Merged
merged 1 commit into from
Oct 15, 2012

Conversation

xsuchy
Copy link
Contributor

@xsuchy xsuchy commented Oct 15, 2012

if file is binary (e.g pdf file) then do not try to convert it to unicode
and print it to log file
additionally execute this part of code only if logging level is set to DEBUG.

if file is binary (e.g pdf file) then do not try to convert it to unicode
and print it to log file
additionally execute this part of code only if logging level is set to DEBUG.
@ozzak
Copy link

ozzak commented Oct 15, 2012

All unit tests are green :-)

... and for absolute majority of programmers additional shared objects mean
additional fsckup sources.  I don't trust them to write correct async code.
OK, so I don't trust the majority of programmers to find their dicks if
you take their Visual Masturbation Aid++ away, but that's another story -
I'm talking about otherwise clued people, not burger-flippers armed with
Foo For Complete Dummies in 24 Hours.

    - Al Viro about multi-threading on linux-kernel

https://gist.github.com/3891847

@lzap
Copy link
Contributor

lzap commented Oct 15, 2012

Heh that was nasty, ACK

xsuchy added a commit that referenced this pull request Oct 15, 2012
866323 - do not print binary files to log
@xsuchy xsuchy merged commit a6ef208 into Katello:master Oct 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants