Refs #29540 - Remove 3.16 deprecated functionality and warnings #8685

jeremylenz · 2020-04-28T16:25:27Z

There are deprecation warnings about functionality to be removed in 3.16. We need to remove the following in 3.16:

Update 5/7/20: per @jlsherrill Puppet and OStree deprecations have been pushed to 4.0, as well as the background download type. I am reverting those commits rather than removing them, so whoever ends up with that task can cherry-pick the originals later and get a bit of a head start.

- [x] Background download type
Deprecation warning at /home/jomitsch/tool_belt/repos/katello/3.15.0/katello/app/lib/actions/katello/repository/update.rb line 16 is marked for removal in version 3.16, which is the next release version.

- [x] Puppet and ostree
Deprecation warning at /home/jomitsch/tool_belt/repos/katello/3.15.0/katello/app/lib/actions/katello/repository/update.rb line 20 is marked for removal in version 3.16, which is the next release version.

- [x] Background download type
Deprecation warning at /home/jomitsch/tool_belt/repos/katello/3.15.0/katello/app/lib/actions/katello/repository/create.rb line 14 is marked for removal in version 3.16, which is the next release version.

- [x] Puppet and ostree
Deprecation warning at /home/jomitsch/tool_belt/repos/katello/3.15.0/katello/app/lib/actions/katello/repository/create.rb line 18 is marked for removal in version 3.16, which is the next release version.

Events API
Deprecation warning at /home/jomitsch/tool_belt/repos/katello/3.15.0/katello/app/controllers/katello/api/v2/host_subscriptions_controller.rb line 58 is marked for removal in version 3.16, which is the next release version.

- [x] Puppet and ostree (create repo)
Deprecation warning at /home/jomitsch/tool_belt/repos/katello/3.15.0/katello/app/controllers/katello/api/v2/repositories_controller.rb line 223 is marked for removal in version 3.16, which is the next release version.

theforeman-bot · 2020-04-28T16:25:33Z

Issues: #29540

This reverts commit 120f8fa.

jturel · 2020-05-08T19:22:21Z

app/controllers/katello/api/v2/host_subscriptions_controller.rb

@@ -56,13 +56,6 @@ def auto_attach
      respond_for_index(:collection => index_response, :template => "index")
    end

-    api :GET, "/hosts/:host_id/subscriptions/events", N_("List subscription events for the host"), :deprecated => true


We should remove the route for this too

took me a minute to find, but that's done now :)

jturel

Looks good. I don't want to merge this branch with all these commits though. I think it'd be better to create a copy of your branch to preserve your work, and make whoever is going to actually remove those other pieces aware of your branch so they can build on it, or replicate it when that time comes. Maybe there's an issue open already that you can comment on with the details.

jturel · 2020-05-08T19:31:22Z

Looks like there's another API to remove:

katello/app/controllers/katello/api/rhsm/candlepin_dynflow_proxy_controller.rb

Line 7 in 93fab73

before_action :deprecated, only: :deb_package_profile

katello/app/controllers/katello/api/rhsm/candlepin_dynflow_proxy_controller.rb

Lines 69 to 71 in 93fab73

    
           def deprecated 
        
             ::Foreman::Deprecation.api_deprecation_warning("it will be removed in Katello 3.15 - please use /consumers/:id/profiles instead.") 
        
           end

cc @mdellweg for awareness

jeremylenz · 2020-05-08T20:22:02Z

@jturel I was thinking squash and merge for this one, since that's turned on again. 😉

jturel · 2020-05-08T20:26:13Z

@jturel I was thinking squash and merge for this one, since that's turned on again. 😉

ACK. But that would contradict your comment (right?)

I am reverting those commits rather than removing them, so whoever ends up with that task can cherry-pick the originals later and get a bit of a head start.

jeremylenz · 2020-05-08T20:30:42Z

@jturel The commits would still be available on the closed pull request, no?

jturel · 2020-05-08T20:34:53Z

@jturel The commits would still be available on the closed pull request, no?

That never occurred to me! mind_blown.gif

mdellweg · 2020-05-09T09:34:41Z

Looks like there's another API to remove:

katello/app/controllers/katello/api/rhsm/candlepin_dynflow_proxy_controller.rb

Line 7 in 93fab73

before_action :deprecated, only: :deb_package_profile

katello/app/controllers/katello/api/rhsm/candlepin_dynflow_proxy_controller.rb

Lines 69 to 71 in 93fab73

def deprecated

::Foreman::Deprecation.api_deprecation_warning("it will be removed in Katello 3.15 - please use /consumers/:id/profiles instead.")

end

cc @mdellweg for awareness

The corresponding candlepin change is still waiting:
candlepin/subscription-manager#2132

jturel · 2020-05-11T12:36:36Z

Looks like there's another API to remove:

katello/app/controllers/katello/api/rhsm/candlepin_dynflow_proxy_controller.rb

Line 7 in 93fab73

before_action :deprecated, only: :deb_package_profile

katello/app/controllers/katello/api/rhsm/candlepin_dynflow_proxy_controller.rb

Lines 69 to 71 in 93fab73

def deprecated

::Foreman::Deprecation.api_deprecation_warning("it will be removed in Katello 3.15 - please use /consumers/:id/profiles instead.")

end

cc @mdellweg for awareness

The corresponding candlepin change is still waiting:
candlepin/subscription-manager#2132

Thanks, guess we'll keep it for now. I guess we should update the deprecation warning for Katello 4.0 and try to get the sub-man PR merged in

jturel · 2020-05-11T15:09:20Z

I just had a look through the code and it appears we're caught up on deprecations with this PR which is awesome. I found this though:

app/controllers/katello/api/v2/hosts_bulk_actions_controller.rb:      ::Foreman::Deprecation.api_deprecation_warning("The 'applicable_hosts' field will be removed from this API in Katello 2.0")
app/controllers/katello/api/v2/hosts_bulk_actions_controller.rb:      ::Foreman::Deprecation.api_deprecation_warning("The 'applicable_hosts' field will be removed from this API in Katello 2.0")

I think these warnings can be removed - I think the associated parameter has been gone for a while

jturel

APJ!

remember to squash ;)

^^ that's a note to self

…llo#8685) * Refs #29540 - remove DOWNLOAD_BACKGROUND type * Refs #29540 - remove hosts/:id/subscriptions/events endpoint * Refs #29540 - remove ostree and puppet in repositories_controller * Refs #29540 - update repositories_controller_test * Refs #29540 - remove deprecation warning from create.rb and update.rb * Refs #29540 - Fix root_repository tests * Refs #29540 - fix some other tests * Refs #29540 - Revert "remove DOWNLOAD_BACKGROUND type" This reverts commit 120f8fa. * Refs #29540 - Revert "remove ostree and puppet in repositories_controller" This reverts commit 1afa706. * Refs #29540 - Revert "update repositories_controller_test" This reverts commit 9e65b13. * Refs #29540 - Revert "remove deprecation warning from create.rb and update.rb" This reverts commit f0441cd. * Refs #29540 - Revert "Fix root_repository tests" This reverts commit d7aa183. * Refs #29540 - bump deprecation warnings for puppet and ostree * Refs #29540 - add back erroneously removed test * Refs #29540 - bump cp_dynflow deprecation warning * Refs #29540 - remove route for events * Refs #29540 - remove old 2.0 warnings

theforeman-bot added Needs testing Not yet reviewed labels Apr 28, 2020

jeremylenz force-pushed the 29540-deprecations-3-16 branch from c264882 to 9e65b13 Compare April 29, 2020 19:20

theforeman-bot added the Waiting on contributor label Apr 29, 2020

jeremylenz force-pushed the 29540-deprecations-3-16 branch from 71455fa to f0441cd Compare April 29, 2020 21:34

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels Apr 29, 2020

jeremylenz force-pushed the 29540-deprecations-3-16 branch from 9ee50de to d7aa183 Compare April 30, 2020 14:54

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels Apr 30, 2020

jeremylenz added 7 commits May 6, 2020 19:54

Refs #29540 - remove DOWNLOAD_BACKGROUND type

0da9566

Refs #29540 - remove hosts/:id/subscriptions/events endpoint

a9e555a

Refs #29540 - remove ostree and puppet in repositories_controller

7d5b6f6

Refs #29540 - update repositories_controller_test

de35978

Refs #29540 - remove deprecation warning from create.rb and update.rb

a0ad085

Refs #29540 - Fix root_repository tests

cf531b4

Refs #29540 - fix some other tests

f92d000

jeremylenz force-pushed the 29540-deprecations-3-16 branch from 0dc96cb to f92d000 Compare May 6, 2020 19:55

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels May 6, 2020

Refs #29540 - Revert "remove DOWNLOAD_BACKGROUND type"

495e537

This reverts commit 120f8fa.

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels May 7, 2020

jeremylenz marked this pull request as ready for review May 7, 2020 21:37

jeremylenz changed the title ~~[WIP] Refs #29540 - Remove 3.16 deprecated functionality and warnings~~ Refs #29540 - Remove 3.16 deprecated functionality and warnings May 7, 2020

Refs #29540 - add back erroneously removed test

76dec51

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels May 8, 2020

jturel reviewed May 8, 2020

View reviewed changes

jturel suggested changes May 8, 2020

View reviewed changes

Refs #29540 - bump cp_dynflow deprecation warning

ab85246

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels May 11, 2020

Refs #29540 - remove route for events

287c148

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels May 11, 2020

Refs #29540 - remove old 2.0 warnings

0cad57c

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels May 11, 2020

jturel approved these changes May 11, 2020

View reviewed changes

jturel merged commit 3b8b8f8 into Katello:master May 11, 2020

jeremylenz deleted the 29540-deprecations-3-16 branch June 8, 2020 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refs #29540 - Remove 3.16 deprecated functionality and warnings #8685

Refs #29540 - Remove 3.16 deprecated functionality and warnings #8685

jeremylenz commented Apr 28, 2020 •

edited

theforeman-bot commented Apr 28, 2020

jturel May 8, 2020

jeremylenz May 11, 2020

jturel left a comment

jturel commented May 8, 2020 •

edited

jeremylenz commented May 8, 2020

jturel commented May 8, 2020

jeremylenz commented May 8, 2020

jturel commented May 8, 2020

mdellweg commented May 9, 2020

jturel commented May 11, 2020

jturel commented May 11, 2020

jturel left a comment •

edited

Refs #29540 - Remove 3.16 deprecated functionality and warnings #8685

Refs #29540 - Remove 3.16 deprecated functionality and warnings #8685

Conversation

jeremylenz commented Apr 28, 2020 • edited

theforeman-bot commented Apr 28, 2020

jturel May 8, 2020

Choose a reason for hiding this comment

jeremylenz May 11, 2020

Choose a reason for hiding this comment

jturel left a comment

Choose a reason for hiding this comment

jturel commented May 8, 2020 • edited

jeremylenz commented May 8, 2020

jturel commented May 8, 2020

jeremylenz commented May 8, 2020

jturel commented May 8, 2020

mdellweg commented May 9, 2020

jturel commented May 11, 2020

jturel commented May 11, 2020

jturel left a comment • edited

Choose a reason for hiding this comment

jeremylenz commented Apr 28, 2020 •

edited

jturel commented May 8, 2020 •

edited

jturel left a comment •

edited