-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #30352 - Add an original mod streams filter #8825
Conversation
Issues: #30352 |
fc908eb
to
fce4550
Compare
fce4550
to
fa8185a
Compare
28dce7b
to
5102700
Compare
Test results with different filters with and without Include all Module Streams with no errata checkbox. Red Hat Enterprise Linux 8 for x86_64 - AppStream RPMs 8 Module Streams: Errata: The functionality is as advertised. Will Ack after playing around some more in a little bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nitpicks.. |
d11513c
to
508ac6d
Compare
This commit allows module streams filters to include Module Streams that do not belong to any errata. This is especially useful when used in conjunction with rpm filters. Refs #30352 - reverting b58687e For more context: `Original` in this context applies to modules that were originally there before errata started coming. We use `--original-packages` for rpm that are not part of any errata. This commit adds `--original-module-streams` for module streams that are not part of errata. Module filters introduced a flaw in master. Since we did not have this --original-module-streams flag, if you did any sort of errata filtering you'd not get modules that do not belong to any errata Many customers want -> 1. All the content in the base + 2. Security errata up until a specified date in their cve so their filters are written the same way This commit aims to fix this scenario
508ac6d
to
4802779
Compare
This commit allows module streams filters to include Module Streams that do not belong to any errata. This is especially useful when used in conjunction with rpm filters. Refs #30352 - reverting b58687e For more context: `Original` in this context applies to modules that were originally there before errata started coming. We use `--original-packages` for rpm that are not part of any errata. This commit adds `--original-module-streams` for module streams that are not part of errata. Module filters introduced a flaw in master. Since we did not have this --original-module-streams flag, if you did any sort of errata filtering you'd not get modules that do not belong to any errata Many customers want -> 1. All the content in the base + 2. Security errata up until a specified date in their cve so their filters are written the same way This commit aims to fix this scenario
This commit allows module streams filters to include Module Streams that do not belong to any errata. This is especially useful when used in conjunction with rpm filters. Refs #30352 - reverting b58687e For more context: `Original` in this context applies to modules that were originally there before errata started coming. We use `--original-packages` for rpm that are not part of any errata. This commit adds `--original-module-streams` for module streams that are not part of errata. Module filters introduced a flaw in master. Since we did not have this --original-module-streams flag, if you did any sort of errata filtering you'd not get modules that do not belong to any errata Many customers want -> 1. All the content in the base + 2. Security errata up until a specified date in their cve so their filters are written the same way This commit aims to fix this scenario (cherry picked from commit 2364a76)
This commit allows module streams filters to include Module Streams that do not belong to any errata. This is especially useful when used in conjunction with rpm filters. Refs #30352 - reverting b58687e For more context: `Original` in this context applies to modules that were originally there before errata started coming. We use `--original-packages` for rpm that are not part of any errata. This commit adds `--original-module-streams` for module streams that are not part of errata. Module filters introduced a flaw in master. Since we did not have this --original-module-streams flag, if you did any sort of errata filtering you'd not get modules that do not belong to any errata Many customers want -> 1. All the content in the base + 2. Security errata up until a specified date in their cve so their filters are written the same way This commit aims to fix this scenario (cherry picked from commit 2364a76)
This commit allows module streams filters to include Module Streams that
do not belong to any errata. This is especially useful when used in
conjunction with rpm filters.
For more context:
Original
in this context applies to modules that were originally there beforeerrata started coming.
We use
--original-packages
for rpm that are not part of any errata.This commit adds
--original-module-streams
for module streams that are not part of errata.Module filters introduced a flaw in master.
Since we did not have this --original-module-streams flag,
if you did any sort of errata filtering you'd not get modules that do not belong to any errata
Many customers want ->
so their filters are written the same way
This PR aims to fix the above scenario