Fixes #31247 - deleting wrong repo reference on cv delete #9038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #31247 |
jlsherrill
commented
Nov 16, 2020
| assert repo_reference | ||
| assert Katello::Pulp3::Api::File.new(@primary).repositories_api.read(repo_reference.repository_href) | ||
|
|
||
| ForemanTasks.sync_task(::Actions::Pulp3::ContentView::DeleteRepositoryReferences, @content_view, @primary) | ||
| refute Katello::Pulp3::RepositoryReference.find_by(:id => repo_reference.id) | ||
|
|
||
| assert Katello::Pulp3::RepositoryReference.find_by(:id => library_repo_ref.id) |
There was a problem hiding this comment.
note that this test reproduces the error on master
ianballou
reviewed
Nov 18, 2020
There was a problem hiding this comment.
This needs an update to get the tests passing: https://github.com/Katello/katello/blob/master/test/support/pulp3_support.rb#L22
ianballou
reviewed
Nov 18, 2020
|
Rubocop error and a VCR issue is remaining. Other issues are the exporter failures. |
previously the wrong repo reference object was deleted
jlsherrill
commented
Nov 24, 2020
| @@ -23,16 +23,14 @@ def test_list_with_pagination | |||
| User.current = users(:admin) | |||
| @primary = FactoryBot.create(:smart_proxy, :default_smart_proxy, :with_pulp3) | |||
|
|
|||
| repo1 = katello_repositories(:pulp3_file_1) | |||
| repo1 = katello_repositories(:generic_file) | |||
There was a problem hiding this comment.
This test wasn't really written properly, notice its creating the same repo in pulp3 twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the wrong repo reference object was deleted