Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #31359 - do not delete repo version 0 #9102

Merged
merged 1 commit into from Jan 19, 2021
Merged

Fixes #31359 - do not delete repo version 0 #9102

merged 1 commit into from Jan 19, 2021

Conversation

jlsherrill
Copy link
Member

if we try to delete a repo version of zero,
just ignore it.

@jlsherrill
Fixes #31359 - do not delete repo version 0
ccee4ea 
if we try to delete a repo version of zero,
just ignore it.
@theforeman-bot
Copy link

Issues: #31359

@jlsherrill
Copy link
Member Author

see redmine for reproducer steps

jjeffers
jjeffers approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@jjeffers jjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test this as per reproduction steps.
Works as described, a+++ would delete CV version again.

APJ

@jlsherrill
Copy link
Member Author

[test katello]

1 similar comment
@jlsherrill
Copy link
Member Author

[test katello]

@jlsherrill jlsherrill merged commit dc5b581 into Katello:master Jan 19, 2021
@jlsherrill jlsherrill deleted the 31359 branch January 19, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjeffers jjeffers jjeffers approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
3 participants
@jlsherrill @theforeman-bot @jjeffers