New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #31270 - Fix applicability with modular vs non-modular rpms #9107
Merged
ianballou
merged 2 commits into
Katello:master
from
ianballou:31270-fix-applicable-modular-rpms
Jan 27, 2021
Merged
Fixes #31270 - Fix applicability with modular vs non-modular rpms #9107
ianballou
merged 2 commits into
Katello:master
from
ianballou:31270-fix-applicable-modular-rpms
Jan 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: #31270 |
ianballou
changed the title
31270 fix applicable modular rpms
Fixes #31270 - Fix applicability with modular vs non-modular rpms
Jan 20, 2021
ianballou
force-pushed
the
31270-fix-applicable-modular-rpms
branch
from
January 20, 2021 19:34
3fd86da
to
5772780
Compare
ianballou
force-pushed
the
31270-fix-applicable-modular-rpms
branch
from
January 20, 2021 19:35
5772780
to
df1176b
Compare
ianballou
force-pushed
the
31270-fix-applicable-modular-rpms
branch
from
January 21, 2021 18:33
df1176b
to
e342ecf
Compare
jlsherrill
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
I reproduced the problem and this pr solved it. Performance seems on par with current levels
ranjan
pushed a commit
to ranjan/katello
that referenced
this pull request
Feb 9, 2021
…tello#9107) * Fixes #31270 - properly ignore non-modular rpms for modular-rpm applicability * Refs #31270 - use enabled modules for modular rpm checking instead
ianballou
added a commit
to ianballou/katello
that referenced
this pull request
Feb 16, 2021
…tello#9107) * Fixes #31270 - properly ignore non-modular rpms for modular-rpm applicability * Refs #31270 - use enabled modules for modular rpm checking instead
jturel
pushed a commit
to jturel/katello
that referenced
this pull request
Mar 4, 2021
…tello#9107) * Fixes #31270 - properly ignore non-modular rpms for modular-rpm applicability * Refs #31270 - use enabled modules for modular rpm checking instead (cherry picked from commit 56fb9e5)
jturel
pushed a commit
that referenced
this pull request
Mar 10, 2021
) * Fixes #31270 - properly ignore non-modular rpms for modular-rpm applicability * Refs #31270 - use enabled modules for modular rpm checking instead (cherry picked from commit 56fb9e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue Katello/Pulp 3 applicability where newer non-modular RPMs are marked as applicable for older modular RPMs. This is not possible since
dnf
locks down modular packages when a related module is enabled, which blocks the installation of non-modular RPMs with the same name as the locked modular ones.To test:
EL8
content host and subscribe ityum module enable walrus:0.71
dnf uploadprofile --force-upload
for good measurewalrus-5.21
should be marked as applicablewalrus-5.21
should disappear from the host's applicabilityTODO: