Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #31839 - Viewer role create CV button #9148

Merged
merged 1 commit into from Feb 9, 2021

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Feb 9, 2021

No description provided.

@theforeman-bot
Copy link

Issues: #31839

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sjha4

Works as expected on the Content Views page:

  • Admin user can see "Create New View" button
  • Viewer user does not have "Create New View" button

On the new /labs/content_views page, Viewer user can still see the Create Content View button. I think a separate issue should be created for this-- should probably make sure all the new CV pages behave as expected with permissions.

@sjha4 sjha4 merged commit 5082180 into Katello:master Feb 9, 2021
@sjha4
Copy link
Member Author

sjha4 commented Feb 9, 2021

ly make sure all the new CV pages behave as expected with permissions.

On the new /labs/content_views page, Viewer user can still see the Create Content View button. I think a separate issue should be created for this-- should probably make sure all the new CV pages behave as expected with permissions.

@jeremylenz Ya I was thinking about that..I'll file a card..

jjeffers pushed a commit to jjeffers/katello that referenced this pull request Feb 17, 2021
jjeffers pushed a commit that referenced this pull request Feb 18, 2021
jturel pushed a commit to jturel/katello that referenced this pull request Mar 4, 2021
jturel pushed a commit that referenced this pull request Mar 10, 2021
jturel pushed a commit to jturel/katello that referenced this pull request Apr 30, 2021
Fixes #31839 - Viewer role create CV button (Katello#9148)

(cherry picked from commit 5082180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants