Fixes #31320 - Remove old button css styling #9154
Conversation
|
Issues: #31320 |
There was a problem hiding this comment.
Thanks for improving our final remaining ERB page in Katello, @jturel :)
Suggestion below.
| @@ -163,78 +163,6 @@ input:focus { | |||
| @extend .status_exclamation_icon; | |||
| } | |||
|
|
|||
| /* BUTTONS */ | |||
| input[type='submit'], button, .button { | |||
There was a problem hiding this comment.
I searched in Chrome dev tools for the CSS from this file, and it's usually not even in the bundle. This entire file appears to only be used for this page (I suspect it would apply to any Katello ERB page, but Sync Status is the only remaining one as far as I know.)
With that said, there's probably even a lot more we could eliminate from this file. However, though this change fixes the problem it makes the "Synchronize Now" button look worse than it was before.
What are your thoughts on doing the following instead:
- Change this line to
input[type='submit']#sync_button {. The button already has an id of "sync_button", so this will make the selector specific enough so that all of the following CSS only affects that button. - Keep
&:hover,&:active, and&:focussections since they make the button interactive and visually pleasing as the pointer moves around. - I agree that we can remove all the sections from
&.dialogbuttondown since they are classes that don't appear to be in use. - In
app/views/katello/sync_management/_products.html.erb, add classes to the button to make it look a bit better: change:class => 'button fr'to:class => 'btn btn-secondary button fr'
There was a problem hiding this comment.
I interpreted the spirit of your feedback and just added btn btn-default to it, and I think it looks pretty good (consistent with pf pages). Let me know what you think
There was a problem hiding this comment.
@jturel When the button is disabled, it's doing a weird thing where it gets a black border if you click on it (I think it's something with border when :active). But a similar behavior is also present in master, so I'll approve and leave it up to you whether you want to spend more time on it.
Other than that, works fine for me :)
ACK. I'm gonna leave the button as-is! |
* Fixes #31320 - Remove old button css styling * Refs #31320 - use patternfly styling on Synchronize Now button
* Fixes #31320 - Remove old button css styling * Refs #31320 - use patternfly styling on Synchronize Now button (cherry picked from commit a09cb40)
* Fixes #31320 - Remove old button css styling * Refs #31320 - use patternfly styling on Synchronize Now button (cherry picked from commit a09cb40)
* Fixes #31320 - Remove old button css styling * Refs #31320 - use patternfly styling on Synchronize Now button (cherry picked from commit a09cb40)
* Fixes #31320 - Remove old button css styling * Refs #31320 - use patternfly styling on Synchronize Now button (cherry picked from commit a09cb40)
…us is whited out Fixes #31320 - Remove old button css styling (Katello#9154) * Fixes #31320 - Remove old button css styling * Refs #31320 - use patternfly styling on Synchronize Now button (cherry picked from commit a09cb40)
This fixes the the whited-out styling on the user dropdown on the top right of the sync status page. It's a little scary removing a large chunk of css like this, but I'm almost positive it's not affecting other pages and that's what I'd like the reviewer to validate. I was able to confirm, at least, that the subclasses like
actionlinkandformbuttonaren't used anymore.