Fixes #31918 - Host Registration - Activation key field improvements #9177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #31918 |
stejskalleos
force-pushed
the
ls/ak_6.9
branch
from
6181d3f
to
696e6ca
Compare
jeremylenz
reviewed
Mar 1, 2021
There was a problem hiding this comment.
Thanks @stejskalleos!
Just one small comment and question below
| <a rel="popover" data-content="<%= help %>" data-trigger="focus" data-container="body" data-html="true" tabindex="-1"> | ||
| <span class="pficon pficon-info "></span> | ||
| </a> | ||
| </label> | ||
| <div class='col-md-4'> | ||
| <%= text_field_tag 'activation_key', params[:activation_key], class: 'form-control' %> | ||
| <%= text_field_tag 'activation_key', params[:activation_key], class: 'form-control', required: true %> |
There was a problem hiding this comment.
This will make the field required regardless of which OS is selected. Is that the intention?
There was a problem hiding this comment.
Yes, for Foreman with Katello we want to make it required regardless of which OS is selected.
This will be changed in Foreman 2.5, where Activation keys will be hidden as advanced field,
and users will use host group as primary source of the data.
There is a redmine PR for it: https://projects.theforeman.org/issues/31240
jeremylenz
approved these changes
Mar 2, 2021
jturel
pushed a commit
to jturel/katello
that referenced
this pull request
Apr 30, 2021
…nd if 'Activation Key' has been kept blank. Fixes #31918 - Host Registration - Activation key field improvements (Katello#9177) (cherry picked from commit e574ca6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.9 BZs: