Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #32060 - only call import applicability when needed #9220

Merged
merged 1 commit into from Mar 12, 2021

Conversation

jlsherrill
Copy link
Member

No description provided.

@theforeman-bot
Copy link

Issues: #32060

@jlsherrill
Copy link
Member Author

Import applicability is only supposed to be used when pulp2 is being used for yum (aka katello_applicability is false). The issue is that this import applicability is being run to pull applicability info from pulp2 when it hasn't even been calculated there. So a race condition exists where by the profile is being calculated by katello and being pulled in by pulp around the same time. Its not super easy to reproduce, but you can see the effects of it.

Without this pr:

  1. on 3.18 configured to use pulp3, sync a repository with errata
  2. register a system, subscribe it to the repo and make sure that errata are applicable
  3. force sync the repository using the advanced sync option select 'complete sync'
  4. go to audits, you'll see something like this:
    image

notice the errata count changed and then immediately changed back

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@jlsherrill jlsherrill merged commit c86b470 into Katello:KATELLO-3.18 Mar 12, 2021
@jlsherrill jlsherrill deleted the 32060 branch March 12, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants