Fixes #32621 - Update useEffect to useDeepCompareEffect #9430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #32621 |
jeremylenz
requested changes
Jun 29, 2021
webpack/scenes/ContentViews/Details/Histories/ContentViewHistories.js
Outdated
Show resolved
Hide resolved
| @@ -49,6 +49,7 @@ | |||
| "downshift": "^5.4.2", | |||
| "ngreact": "^0.5.0", | |||
| "query-string": "^6.1.0", | |||
| "react-bootstrap": "^0.32.1" | |||
| "react-bootstrap": "^0.32.1", | |||
| "use-deep-compare-effect": "^1.6.1" | |||
There was a problem hiding this comment.
Let's move this dependency to https://github.com/theforeman/foreman-js/blob/83c486fef9f37eb2b9b101203e316c1b77d759f2/packages/vendor-core/package.json#L90 (Please open a PR in foreman-js)
That way Foreman can benefit from it too :)
Once it's merged there, Katello will pick it up and this line won't be needed.
|
We can merge this and let the foreman-js PR get comments and we can use that if it's accepted. 👍🏽 |
|
@parthaa looks like there's 1 test failure, maybe it needs a rebase? |
Update webpack/scenes/ContentViews/Details/Histories/ContentViewHistories.js Co-authored-by: Jeremy Lenz <jlenz@redhat.com>
|
This broke packaging. theforeman/foreman-packaging#6844 was opened to add it, but it's not clear to me if this should be in foreman-js or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.