Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #33036 - Make via Katello-agent option clickable on content host errata page #9479

Merged
merged 1 commit into from Jul 20, 2021

Conversation

lfu
Copy link
Member

@lfu lfu commented Jul 19, 2021

find_bulk_errata_ids expects bulk_errata_ids in JSON string format.

Followup of #9470.

@theforeman-bot
Copy link

Issues: #33036

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After enabling the katello-agent with the installer and applying the patch. I can see the option now. Thanks for updating the tests too. ACK @jturel does this correct now?

@jturel
Copy link
Member

jturel commented Jul 20, 2021

After enabling the katello-agent with the installer and applying the patch. I can see the option now. Thanks for updating the tests too. ACK @jturel does this correct now?

Code LGTM - does the errata install actually work via agent?

@jturel
Copy link
Member

jturel commented Jul 20, 2021

I'm also curious (not questioning the fix whatsoever) how this prevented the button from being clickable?

@lfu
Copy link
Member Author

lfu commented Jul 20, 2021

I'm also curious (not questioning the fix whatsoever) how this prevented the button from being clickable?

This is also my question. UI world seems mystic to me. Wondering if @jeremylenz has any clue.

@jeremylenz
Copy link
Member

My guess is that an error was being thrown during execution of HostErratum.apply() because of the incorrect parameter, so its callback (unselecting all boxes and redirecting to task details) never happened. But to verify I'd need an Angular expert like @chris1984 or @parthaa ;)

@jturel
Copy link
Member

jturel commented Jul 20, 2021

I'm also curious (not questioning the fix whatsoever) how this prevented the button from being clickable?

This is also my question. UI world seems mystic to me. Wondering if @jeremylenz has any clue.

Was there an error in the javascript console or rails log prior to the change? That would explain it I think!

@chris1984
Copy link
Member

Will do full end to end testing and report back

@lfu
Copy link
Member Author

lfu commented Jul 20, 2021

Was there an error in the javascript console or rails log prior to the change? That would explain it I think!

Yes, there was an error in rails log.

2021-07-19T19:52:12 [E|app|2c98a9ca] TypeError: no implicit conversion of ActionController::Parameters into String

@chris1984
Copy link
Member

Screenshot of UI showing dropdown correctly:

https://nimb.ws/N3ZidS

Screenshot of katello-agent correctly installing the sea_erratum errata

https://nimb.ws/lwvXZQ

End to end testing works correctly.

Copy link
Member

@jturel jturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great teamwork on getting to the bottom of this one. Thanks all!

ACK

@jturel jturel merged commit b31dcd8 into Katello:master Jul 20, 2021
@lfu lfu deleted the k_agent_errata_ui_33036 branch July 29, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants