Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #33495 - yum metadata checksum not correct in Pulp #9641

Merged
merged 1 commit into from Sep 17, 2021
Merged

Fixes #33495 - yum metadata checksum not correct in Pulp #9641

merged 1 commit into from Sep 17, 2021

Conversation

ianballou
Copy link
Member

To test:

  1. Sync a repo and choose a "Yum Metadata Checksum" such as "sha1".
  2. Check the repo's publication_href in Pulp:
pulp rpm publication show --href <href>
  1. See that, without my PR, the "metadata_checksum_type" and "package_checksum_type" do not match what is on the Katello repo.

rverdile
rverdile reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@rverdile rverdile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First test looks good! I synced https://fixtures.pulpproject.org/rpm-with-sha-512/.

Without the changes, selecting any of Default, sha256, or sha1 for Yum Metadata still showed this in pulp:

"metadata_checksum_type": "sha512",
"package_checksum_type": "sha512",

With the changes, these fields showed "sha512", "sha256", and "sha1" for Default, sha256, and sha1 respectively.

jlsherrill
jlsherrill approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@jlsherrill jlsherrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

official ack!

@ianballou ianballou merged commit d2ea313 into Katello:master Sep 17, 2021
@ianballou ianballou deleted the 33495-repo-checksum-type-wrong branch September 17, 2021 21:42
Andrewgdewar pushed a commit to Andrewgdewar/katello that referenced this pull request Sep 20, 2021
@ianballou @Andrewgdewar
Fixes #33495 - yum metadata checksum not correct in Pulp (Katello#9641)
da26225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rverdile rverdile rverdile left review comments

@jlsherrill jlsherrill jlsherrill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ianballou @jlsherrill @rverdile