Fixes #33404 - ComponentView Version Details/Routing #9657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #33403 |
Andrewgdewar
force-pushed
the
feature33404
branch
from
f39d805
to
5dbc3c6
Compare
Andrewgdewar
changed the title
Andrewgdewar
force-pushed
the
feature33404
branch
3 times, most recently
from
d54a925
to
286aa69
Compare
Andrewgdewar
requested review from
sjha4 and
jeremylenz
and removed request for
sjha4
Andrewgdewar
force-pushed
the
feature33404
branch
from
286aa69
to
3a5e6fe
Compare
|
We need to update links on versions list page content cells to go to the corresponding versions details content sub-tab. |
sjha4
reviewed
Sep 23, 2021
webpack/scenes/ContentViews/Details/Filters/ContentViewFilters.js
Outdated
Show resolved
Hide resolved
sjha4
reviewed
Sep 23, 2021
webpack/scenes/ContentViews/Details/Versions/VersionDetails/ContentViewVersionDetailConfig.js
Show resolved
Hide resolved
jeremylenz
reviewed
Sep 23, 2021
webpack/scenes/ContentViews/Details/Versions/VersionDetails/ContentViewVersionRepositoryCell.js
Show resolved
Hide resolved
sjha4
reviewed
Sep 24, 2021
webpack/scenes/ContentViews/Details/Versions/VersionDetails/ContentViewVersionDetailConfig.js
Outdated
Show resolved
Hide resolved
Andrewgdewar
force-pushed
the
feature33404
branch
3 times, most recently
from
a3c8486
to
d76b4c0
Compare
|
I get this console error sometimes on the pages on this branch..Not sure where it's coming from and doesn't affect anything on the page..Just shows up in the console: |
Andrewgdewar
force-pushed
the
feature33404
branch
2 times, most recently
from
55e1583
to
a892347
Compare
sjha4
reviewed
Sep 29, 2021
sjha4
reviewed
Sep 29, 2021
sjha4
reviewed
Sep 29, 2021
Andrewgdewar
force-pushed
the
feature33404
branch
from
a892347
to
b24ba58
Compare
sjha4
reviewed
Sep 29, 2021
webpack/scenes/ContentViews/Details/Versions/VersionDetails/ContentViewVersionDetails.js
Show resolved
Hide resolved
Andrewgdewar
force-pushed
the
feature33404
branch
from
b24ba58
to
71f8c6b
Compare
sjha4
reviewed
Sep 29, 2021
webpack/scenes/ContentViews/Details/Versions/VersionDetails/ContentViewVersionRepositoryCell.js
Show resolved
Hide resolved
sjha4
reviewed
Sep 29, 2021
Andrewgdewar
force-pushed
the
feature33404
branch
from
71f8c6b
to
b5eb2cc
Compare
sjha4
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.