New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #33720 - Move collections to generic UI #9731
Conversation
Issues: #33720 |
85712ca
to
0c717cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think content_type in GenericContentType can be removed since it's being initialized in ContentType
katello/app/services/katello/repository_type.rb
Lines 160 to 168 in 0c717cd
class GenericContentType < ContentType | |
attr_accessor :pulp3_api, :pulp3_model, :content_type, :filename_key, :duplicates_allowed, :pluralized_name, | |
:model_name, :model_version, :model_filename | |
def initialize(options) | |
super | |
self.pulp3_api = options[:pulp3_api] | |
self.pulp3_model = options[:pulp3_model] | |
self.content_type = options[:content_type] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the old UI url be legacy/ansible_collections
to be consistent with content views, legacy/content_views
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I fixed this in my PR, but it looks like the repositories tab for content view details is still broken. I'm gonna look into why that is.
Other than that, everything looks good! Not finding any other issues.
This was caused by ostree, so it's nothing to worry about here. |
0c717cd
to
c872a12
Compare
[test katello] |
c872a12
to
957ab65
Compare
@sjha4, this pull request is currently not mergeable. Please rebase against the master branch and push again. If you have a remote called 'upstream' that points to this repository, you can do this by running:
This message was auto-generated by Foreman's prprocessor |
957ab65
to
fd19776
Compare
{ | ||
title: __('Product'), | ||
getProperty: unit => | ||
<a href={urlBuilder(`products/${unit?.product.id}/`, '')}>{unit?.product.name}</a>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very small thing, but there's an extra slash on the end here. products/${unit?.product.id}/
<----
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There's that one slash I pointed out, but that doesn't really break anything.
fd19776
to
33545ca
Compare
What are the changes introduced in this pull request?
Move ansible collections to the new generic unit page.
What are the testing steps for this pull request?
To Do: