Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #33855 - Allow adding filter on same RPM name with different architectures #9767

Merged
merged 1 commit into from Nov 11, 2021
Merged

Fixes #33855 - Allow adding filter on same RPM name with different architectures #9767

merged 1 commit into from Nov 11, 2021

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Nov 5, 2021

What are the changes introduced in this pull request?

Allow adding filter on same RPM name with different architectures

What is the thinking behind these changes?

What are the testing steps for this pull request?

Steps to Reproduce:

  1. Create/ Use a CV
  2. Create a Package filter on the CV
  3. Add rule: name = test, architecture = x86_64, version = all version
  4. Hit save
  5. Add another rule: name = test, architecture = i686, version = all version
  6. Hit save

User should be allowed to create 2 filter rules with diff architectures.

@theforeman-bot
Copy link

Issues: #33855

ianballou
ianballou approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine for me!

@sjha4 sjha4 merged commit 92d6184 into Katello:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianballou ianballou ianballou approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed Waiting on contributor
Projects
None yet
Milestone
No milestone
3 participants
@sjha4 @theforeman-bot @ianballou