Fixes #33893 - fix smart proxy sync with blank url #9775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #33893 |
jjeffers
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
We stopped checking remotes to see if they need updates due to the issue around that check. (Thinks like password and certs are not provided by pulp so will always show as needing updates). It seems the code for smart proxy syncing was comparing the remote config on the SP to the one that was supposed to be on the main pulp server. This was incorrect, and would have always been returning true! Except it seems that this completely errors if the repository has no url
What is the thinking behind these changes?
Skip the remote comparison like we do for regular repo syncs
What are the testing steps for this pull request?