Fixes #34345 - Download rate setting for remotes #9910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #34345 |
rverdile
force-pushed
the
download-rate
branch
7 times, most recently
from
a736ec9
to
175ea87
Compare
rverdile
force-pushed
the
download-rate
branch
from
175ea87
to
8811ba0
Compare
rverdile
changed the title
|
@rverdile sadly, this needs a rebase. shouldn't affect my testing though since it looks isolated to the vcr cassettes! |
jturel
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
I see the rate_limit being set on the pulp3 remote:
pulpcore=# select name, rate_limit from core_remote;
name | rate_limit
---------------------------------------------------------------------------+------------
2_duplicate |
pulp-uuid-rhel_6_x86_64 |
RHN_Tools_for_Red_Hat_Enterprise_Linux_6_Server_RPMs_x86_64_6Server-63190 | 0
Red_Hat_Satellite_Tools_6_9_for_RHEL_8_x86_64_RPMs-199753 | 0
AnimalsSHA512-643304 | 1
NeededErrata-567752 | 0
9 |
APJ!
theforeman-bot
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
@rverdile, this pull request is currently not mergeable. Please rebase against the master branch and push again. If you have a remote called 'upstream' that points to this repository, you can do this by running: This message was auto-generated by Foreman's prprocessor |
rverdile
force-pushed
the
download-rate
branch
from
8811ba0
to
8c324f8
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
rverdile
force-pushed
the
download-rate
branch
from
8c324f8
to
65d015b
Compare
sbernhard
pushed a commit
to ATIX-AG/katello
that referenced
this pull request
May 12, 2022
(cherry picked from commit 7776b81)
Manisha15
pushed a commit
to ATIX-AG/katello
that referenced
this pull request
Jun 15, 2022
(cherry picked from commit 7776b81)
sbernhard
pushed a commit
to ATIX-AG/katello
that referenced
this pull request
Jul 18, 2022
(cherry picked from commit 7776b81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adds global setting "Download Rate Limit" which is used to set maximum rate limit when syncing.
Considerations taken when implementing this change?
The setting is global to affect all repositories.
"Use 0 for no limit" may be an unnecessary clarification. Not sure if that's a known interaction with settings.
What are the testing steps for this pull request?
pulp show --href <remote href>to see that the remote gets the download rate.