Fixes #34508 - Creating repo stop working after any validation error #9974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #34508 |
chris1984
added
Ready for merge
and removed
Needs testing
Not yet reviewed
Waiting on contributor
labels
chris1984
approved these changes
Mar 1, 2022
ianballou
pushed a commit
to ianballou/katello
that referenced
this pull request
Mar 1, 2022
…atello#9974) (cherry picked from commit 232dfc9)
parthaa
pushed a commit
to parthaa/katello
that referenced
this pull request
Apr 11, 2022
…e first save. Fixes #34508 - Creating repo stop working after any validation error (Katello#9974) (cherry picked from commit 232dfc9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Creating a repo fails if there has been a validation error once. ex: create a repo with duplicate name.
Also, updating a docker repo fails if you add a comma at the end of include tags or exclude tags in the form.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Create a repo with an existing name, or negative retain package count value etc to trigger a validation error.
Correct the repo in the form to be valid
It should be able to save properly.
Create a docker repo with some include tags and exclude tags.
You should be able to update the same repo with changes to the tag lists or otherwise.