Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #34528 - Show puppet module count on composite cv add page #9985

Merged
merged 1 commit into from Mar 8, 2022

Conversation

chris1984
Copy link
Member

What are the changes introduced in this pull request?

  • Looking through the code, we deleted a method for the puppet module count, so recreated that and added a test on the method.

Considerations taken when implementing this change?

  • Made sure nothing else broke around that area.

What are the testing steps for this pull request?

  • Spin up a Katello 3.18 or Sat 6.9 box
  • Create a custom product and repo of puppet type
  • Upload a puppet module
  • Create a content view with the puppet module and publish
  • Create a composite content view and add the content view, see that the puppet count is 0
  • Apply patch and restart services
  • Verify module count is correctly showing

@theforeman-bot
Copy link

Issues: #34528

@lfu
Copy link
Member

lfu commented Mar 7, 2022

Screenshot from 2022-03-07 11-22-19
Puppet Modules count went from 0 to 1 after applying the fix.

@lfu
Copy link
Member

lfu commented Mar 7, 2022

APJ

@chris1984 chris1984 merged commit f60f119 into Katello:KATELLO-3.18 Mar 8, 2022
@chris1984 chris1984 deleted the puppet branch March 8, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants