-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #34432 - Remove drpm from ignorable_content for roots #9986
Conversation
Issues: #34432 |
8a2e53f
to
7ebfe53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration forward works! Did you want it to be able to rollback? Or should it be irreversible? Right now if you rollback it doesn't do anything.
I don't think there's any way to make this reversible cause once the migration is run, we have no way of knowing which repos had drpm in ignorable content during rollback. |
Good point. Do you think it needs "IrreversibleMigration"? |
@rverdile : Updated.. 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…O-4.1' Fixes #34432 - Remove drpm from ignorable_content for roots (Katello#9986) See merge request Engineering/orcharhino/dependencies/katello!69
What are the changes introduced in this pull request?
Adds a migration to remove drpm from irgnorable_content list for root repositories.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
How I tested this:
IGNORABLE_CONTENT_UNIT_TYPES = %w(srpm drpm).freeze
repo_params[:ignorable_content] = ['srpm', 'drpm']
Katello::RootRepository.select {|r| r&.ignorable_content&.include? "drpm"}
Katello::RootRepository.select {|r| r&.ignorable_content&.include? "drpm"}
. You shouldn't have any records.