New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #34527 - Add Host Collections card #9990
Refs #34527 - Add Host Collections card #9990
Conversation
Issues: #34527 |
98df478
to
2f05670
Compare
Tests added, ready for review |
c6c6f2f
to
e671c3c
Compare
webpack/components/extensions/HostDetails/Cards/__tests__/hostCollectionsCard.test.js
Show resolved
Hide resolved
Code looks good starting to test |
Out of scope for this pr but I noticed we are changing a lot of rabl lately and we have like 1% test coverage in that area: https://github.com/Katello/katello/tree/master/test/views/api/v2 Do you think we should starting adding tests for when we change rabl? |
Rabl is a view and we don't really test views too much, so I don't think it's needed in general |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK,
Works great screenshot of host collections with expanded description:
Screenshot of host without any host collections:
I didn't see any console errors while clicking around on the card.
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
I used flexbox rather than a table since it's such a simple layout. It worked out pretty well.
I had to add a few attributes to the rabl for host collections.
Dropdown menu items are disabled for now - they will be enabled in upcoming PRs.
What are the testing steps for this pull request?