Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla score test #113

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Vanilla score test #113

wants to merge 25 commits into from

Conversation

ekatsevi
Copy link
Member

@ekatsevi ekatsevi commented Apr 19, 2024

This pull request includes the following new features:

  • There is a new argument in set_analysis_parameters called response_regression_method, which can take values approximate_nb (what we were doing previously) and nb (a new option involving running an NB response regression). The print() function now displays the response regression method.
  • The argument resampling_approximation now has the option standard_normal, which bypasses any resampling and instead compares the test statistic to N(0,1). Note that this option requires response_regression_method = "nb". This functionality is accompanied by the test named "run_calibration_check with score test".
  • The option resampling_mechanism = "crt" is now available for ondisc-backed sceptre objects.

ekatsevi and others added 23 commits February 20, 2024 17:31
…to no_approximation if resampling_mechanism == asymptotic_normality
…to no_approximation if resampling_mechanism == asymptotic_normality
@ekatsevi ekatsevi marked this pull request as draft April 19, 2024 22:14
@ekatsevi ekatsevi changed the title Score test Vanilla score test Apr 20, 2024
@ekatsevi
Copy link
Member Author

ekatsevi commented Apr 20, 2024

A few other notes:

  • Checking the package examples takes upwards of 20 minutes, with check() reporting about 20 or so functions whose examples require more than five seconds. I don't know if this is a problem.
  • Rebuilding the vignette appears to takes a while as well; I skipped it when checking the package.
  • I removed the package R.utils from the sceptre dependencies, because apparently sceptre no longer depends on this package.

@ekatsevi ekatsevi marked this pull request as ready for review April 20, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants