CR's fixes: rename functions

Kava-Labs · May 3, 2024 · 27126aa · 27126aa
1 parent c2e188f
commit 27126aa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/x/evm/types/params.go b/x/evm/types/params.go
@@ -209,18 +209,19 @@ func validateEnabledPrecompiles(enabledPrecompiles []string) error {
 		addrs[i] = common.HexToAddress(precompile)
 	}
 
-	if err := checkIfSortedInBytesRepr(addrs); err != nil {
+	if err := validateSortingInBytesRepr(addrs); err != nil {
 		return fmt.Errorf("enabled precompiles are not sorted: %v", err)
 	}
 
-	if err := checkIfUniqueInBytesRepr(addrs); err != nil {
+	if err := validateUniquenessInBytesRepr(addrs); err != nil {
 		return fmt.Errorf("enabled precompiles are not unique: %v", err)
 	}
 
 	return nil
 }
 
-func checkIfSortedInBytesRepr(addrs []common.Address) error {
+// validateSortingInBytesRepr checks if bytes representation of addresses are sorted in ascending order
+func validateSortingInBytesRepr(addrs []common.Address) error {
 	n := len(addrs)
 
 	for i := 0; i < n-1; i++ {
@@ -233,7 +234,8 @@ func checkIfSortedInBytesRepr(addrs []common.Address) error {
 	return nil
 }
 
-func checkIfUniqueInBytesRepr(addrs []common.Address) error {
+// validateUniquenessInBytesRepr checks if bytes representation of addresses are unique
+func validateUniquenessInBytesRepr(addrs []common.Address) error {
 	n := len(addrs)
 
 	exists := make(map[common.Address]struct{}, n)

diff --git a/x/evm/types/params_test.go b/x/evm/types/params_test.go
@@ -148,7 +148,7 @@ func TestEnabledPrecompilesAddressCorrectness(t *testing.T) {
 	}
 }
 
-func TestEnabledPrecompilesOrderInBytesRepr(t *testing.T) {
+func TestEnabledPrecompilesSortingInBytesRepr(t *testing.T) {
 	const (
 		addr1 = "0x1000000000000000000000000000000000000000"
 		addr2 = "0x2000000000000000000000000000000000000000"