feat: add ERC20KavaWrappedNativeCoin contract #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setup make to compile ERC20KavaWrappedNativeCoin * write & compile contract * also, update openzeppelin
pirtleshell
commented
May 18, 2023
| @@ -0,0 +1,46 @@ | |||
| // SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
This is the primary file that needs review.
I've extended the generic ERC20 to be Ownable and exposed the following methods:
- customizable decimals on deploy -> requires overriding decimals() view
- mint() exposed for the contract owner which will be the evmutil module
- burn() exposed for the contract owner which will be the evmutil module
1 task
|
Since this will end up on mainnet, we should set a fixed solc version, turn optimizations on, and ensure the evm version setting is targeting non-london chains. |
|
Also, it may be a trivial contract, but we should also unit test this similary to https://github.com/Kava-Labs/kava-bridge/blob/main/contract/test/erc20_test.ts to ensure we got the functionality correct, and it stays correct if we change it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe soon this contract will be moved to kava repo proper.