Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evmutil): add ERC20KavaWrappedNativeCoinContract #1591

Merged
merged 3 commits into from
May 23, 2023

Conversation

pirtleshell
Copy link
Member

@pirtleshell pirtleshell commented May 18, 2023

Description

  • adds the contract ABI & bytecode for an Ownable ERC20 with the following:
    • customizable decimals on deploy -> requires overriding decimals() view
    • mint() exposed for the contract owner which will be the evmutil module
    • burn() exposed for the contract owner which will be the evmutil module
  • sets up keeper to deploy above token based on details from an AllowedNativeCoinERC20Token
  • tests basic queries and permissions of deployed contract

The chain does not use this new deploy method yet. I intend to add MsgConvertNativeCoinToERC20 in my next PR. It will use this deployment code upon first conversion of tokens defined in the allowed_native_denoms param.

See contract code here: #1594 (this branch is based on that pr)

Checklist

  • Changelog has been updated as necessary.

@pirtleshell
Copy link
Member Author

converted to draft until merge of #1594 which pulls the contract directly into this repo.

will rebase onto that once reviewed & merged.

@pirtleshell pirtleshell changed the base branch from rp-sdk-coins-to-evm to rp-erc20-contract-for-native-coins May 19, 2023 17:35
x/evmutil/keeper/erc20.go Outdated Show resolved Hide resolved
x/evmutil/keeper/erc20.go Outdated Show resolved Hide resolved
Copy link
Contributor

@galxy25 galxy25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending resolutions of comments

@pirtleshell pirtleshell force-pushed the rp-erc20-contract-for-native-coins branch from f1eaf5a to 256cc39 Compare May 19, 2023 23:06
Base automatically changed from rp-erc20-contract-for-native-coins to master May 19, 2023 23:39
* adds the contract ABI & bytecode for an Ownable erc20 with the following:
  * customizable decimals on deploy -> requires overriding decimals() view
  * mint() exposed for the contract owner which will be the evmutil module
  * burn() exposed for the contract owner which will be the evmutil module
* sets up keeper to deploy above token based on details from an
  AllowedNativeCoinERC20Token
* tests basic queries and permissions of deployed contract
@pirtleshell pirtleshell marked this pull request as ready for review May 19, 2023 23:44
@pirtleshell pirtleshell merged commit 278f785 into master May 23, 2023
8 checks passed
@pirtleshell pirtleshell deleted the rp-deploy-erc20s branch May 23, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants