-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(evmutil): add ERC20KavaWrappedNativeCoinContract #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converted to draft until merge of #1594 which pulls the contract directly into this repo. will rebase onto that once reviewed & merged. |
cd9d3a0
to
b3001e2
Compare
galxy25
reviewed
May 19, 2023
galxy25
reviewed
May 19, 2023
galxy25
reviewed
May 19, 2023
galxy25
reviewed
May 19, 2023
galxy25
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending resolutions of comments
f1eaf5a
to
256cc39
Compare
b3001e2
to
c977fc8
Compare
* adds the contract ABI & bytecode for an Ownable erc20 with the following: * customizable decimals on deploy -> requires overriding decimals() view * mint() exposed for the contract owner which will be the evmutil module * burn() exposed for the contract owner which will be the evmutil module * sets up keeper to deploy above token based on details from an AllowedNativeCoinERC20Token * tests basic queries and permissions of deployed contract
3683b36
to
2e5ddbe
Compare
DracoLi
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The chain does not use this new deploy method yet. I intend to add
MsgConvertNativeCoinToERC20
in my next PR. It will use this deployment code upon first conversion of tokens defined in theallowed_native_denoms
param.See contract code here: #1594 (this branch is based on that pr)
Checklist