Block eth msgs from authz #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nddeluca
approved these changes
May 6, 2022
karzak
approved these changes
May 6, 2022
karzak
added a commit
that referenced
this pull request
May 10, 2022
* kava-10 upgrade instructions (#1227) * migrate doc for kava 10 * update wording * height & time update * update to 4 hours before failure * correct times & block height * add rollback doc Co-authored-by: karzak <kjydavis3@gmail.com> * e2e test for kava 9 -> kava 10 migration (#1232) * e2e test for kava9 export * fix bad chain id * fix unsafe-reset-all cmd reference (#1235) * update upgrade time to account for most recent data (#1236) * disable fee market for kava v0_17 migration (#1237) * Update committee permissions for kava-10 (#1234) * add committee migration skeleton * add helper methods to help modify permissions * modify permissions in migration * tidy up committee migrations into own file * allow semi-colon separate of gas prices on app.toml without crashing (#1239) when setting the base app min gas price * Fix unsafe-reset-all command (#1238) * hack to set tendermint config correctly * Revert "hack to set tendermint config correctly" This reverts commit d34150a. * update cosmos-sdk to include env prefix fix * update address (#1242) * disable london fork for kava 10 evm and dev chain (#1240) * Correct date * Block eth msgs from authz (#1241) * add decorator to block msgs in authz * add to antehandler * prevent vesting msgs skirting block via authz * handle edge case of nested exec msgs * test case to ensure msgs only blocked inside authz * add app integration test * tidy up error msg * dep: update to latest ethermint (#1243) * dep: update to latest ethermint * Update to v17.2 with gas price endpoint fix Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> * use master branch of tm-db to avoid questions about imports (#1244) * tidy up go.mod and update cosmos-sdk fork version for v0.45.4 (#1245) * update makefile build tags (#1246) * gofumpt - apply format changes for readability and consistency (#1248) * update tm-db to kava fork for rocksdb 7.1.2 support w/ grocksdb, (#1249) snapshot dir fix * remove migration cmd for testnet * add migration code for auction & incentive from v0.17.0-testnet * add store loader for new modules; add migration handler to run migrations, then update evm & fee market state * fix module version map initialization Co-authored-by: Draco Li <draco@dracoli.com> Co-authored-by: karzak <kjydavis3@gmail.com> Co-authored-by: Ruaridh <rhuairahrighairidh@users.noreply.github.com> Co-authored-by: Kevin Davis <karzak@users.noreply.github.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
MsgEthereumTxexecuted in aauthz.MsgExecwill be sent directly to the evm msg_server and skip the ethereum antehandler. This will likely cause problems with gas or sig checking.This PR blocks
MsgEthereumTxs from being used in authz by rejecting them in the antehandler. It also expands the existing block ofMsgCreateVestingAccountto prevent use through authz.The block handles the edge case of authz msgs being wrapped in authz msgs (eg a
MsgExecthat runs anotherMsgExecthat runs aMsgEthereumTx) by recursively checking msgs.