bug: fix invalid accumulation time genesis validation #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galxy25
approved these changes
Apr 12, 2023
pirtleshell
commented
Apr 12, 2023
pirtleshell
changed the title
rhuairahrighairidh
approved these changes
Apr 12, 2023
pirtleshell
force-pushed
the
rp-update-max-accumulation
branch
from
1e55c35
to
81e6735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mainnet genesis exports fail validation checks due to incentive accumulation times being more than a year ago. This PR removes the faulty validation, replacing it instead with a check that ensures the value is set. This way, no matter how much time passes, an exported genesis will still have a valid accumulation time value while still preventing misconfiguration from rewarding from the beginning of the unix epoch.
before:
after:
Checklist