Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update x/community lend withdraw proposal to keep funds in x/community #1755

Merged
merged 2 commits into from Oct 25, 2023
Merged

Update x/community lend withdraw proposal to keep funds in x/community #1755

merged 2 commits into from Oct 25, 2023

Conversation

drklee3
Copy link
Member

@drklee3 drklee3 commented Oct 24, 2023 •
edited

Description

  • Remove transfer of funds from x/community to x/distribution community pool after lend withdraw

Checklist

  • Changelog has been updated as necessary.

@drklee3 drklee3 marked this pull request as ready for review October 24, 2023 21:58
rhuairahrighairidh
rhuairahrighairidh approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@rhuairahrighairidh rhuairahrighairidh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does HandleCommunityPoolLendDepositProposal need to be updated to not use the pool as well? Looks like it will always fail once the pool is empty.

@nddeluca
Copy link
Member

Does HandleCommunityPoolLendDepositProposal need to be updated to not use the pool as well? Looks like it will always fail once the pool is empty.

We decided to leave it untouched in-case we want to use it before 2024 to deposit funds from distribution and there are not strong reasons to change for the stability committee

@drklee3 drklee3 merged commit adbd70f into master Oct 25, 2023
10 checks passed
@drklee3 drklee3 deleted the dl-community-withdraw-lend branch October 25, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nddeluca nddeluca nddeluca approved these changes

@rhuairahrighairidh rhuairahrighairidh rhuairahrighairidh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drklee3 @nddeluca @rhuairahrighairidh