Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set validator minimum commissions to at least 5% in upgrade handler #1761

Merged
merged 8 commits into from Oct 31, 2023
Merged

feat: set validator minimum commissions to at least 5% in upgrade handler #1761

merged 8 commits into from Oct 31, 2023

Conversation

drklee3
Copy link
Member

@drklee3 drklee3 commented Oct 26, 2023 •
edited

Description

  • Iterates over all validators and modifies those with <5% commission, setting them to 5%

Checklist

  • Changelog has been updated as necessary.

@drklee3 drklee3 marked this pull request as ready for review October 26, 2023 20:25
pirtleshell
pirtleshell approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@pirtleshell pirtleshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Closes #1573

@pirtleshell pirtleshell mentioned this pull request Oct 30, 2023
Closed
1 task
@drklee3 drklee3 merged commit 1746f51 into dl-incentive-e2e Oct 31, 2023
3 checks passed
@drklee3 drklee3 deleted the dl-val-min-commission branch October 31, 2023 21:16
drklee3 added a commit that referenced this pull request Oct 31, 2023
@drklee3
feat: set validator minimum commissions to at least 5% in upgrade han…
b58577d 
…dler (#1761)

* Update validator min commission in upgrade

* Add min commission upgrade test

* Update changelog

* Set validator MaxRate, call BeforeValidatorModified hook

* Check max commission and update time in tests

* Update e2e test for max rate

* Test val update time

* Use SdkBlock instead of Block
drklee3 added a commit that referenced this pull request Oct 31, 2023
@drklee3
feat: set validator minimum commissions to at least 5% in upgrade han…
2d742e0 
…dler (#1761)

* Update validator min commission in upgrade

* Add min commission upgrade test

* Update changelog

* Set validator MaxRate, call BeforeValidatorModified hook

* Check max commission and update time in tests

* Update e2e test for max rate

* Test val update time

* Use SdkBlock instead of Block
drklee3 added a commit that referenced this pull request Oct 31, 2023
@drklee3 @DracoLi
x/community events and e2e test improvements (#1766)
6998196 
* Initial e2e setup

* Fix inflation disable tests

* Add upgrade handler

* Add param tests for after upgrade

* Replace deprecated grpc creds

* Remove upgrade for e2e test

* Update upgrade handler to set x/community params

* Remove params check in upgrade

* Update tests for switchover time and params check

* wip inflation

* Add attribute to disable inflation event

* Add before/after switchover mint and dist checks

* Add missing attribute to disable inflation test check

* Check mint events are 0

* Check total supply doesn't change

* Check inflation and events before switchover

* Check staking reward payouts from x/community

* move events funcs to util

* Add keyring to chain, fetch keys from kvtool and test withdrawal

* Remove duplicate KavaHomePath

* Update subtest names to specify before/after switchover

Co-authored-by: Draco <draco@dracoli.com>

* Use blocktime for InflationStop event DisableTime

* Test 5 blocks for staking rewards payout

* Remove logging and unused lines

* Check val claimed balance with queried

* Enable and update consolidation tests

* Update test for modified EventTypeInflationStop time attr

* Test x/distribution community tax

* Fix test names

* Update e2e tests for better live network test support (#1749)

* Update e2e tests to support mirrornet

* Skip claim rewards on live network, require no errors for existing tests

* Update readme with upgrade height

* Update .env example with usdt contract address

* Restore .env file to original local e2e

* Log community params when set

* Make AttributeKeyInflationDisableTime more precise

* Add mainnet and testnet community params (#1753)

* Re-enable ibc tests

* Remove duplicate types.EventTypeInflationStop emit

* feat: set validator minimum commissions to at least 5% in upgrade handler (#1761)

* Update validator min commission in upgrade

* Add min commission upgrade test

* Update changelog

* Set validator MaxRate, call BeforeValidatorModified hook

* Check max commission and update time in tests

* Update e2e test for max rate

* Test val update time

* Use SdkBlock instead of Block

* Remove upgrade related handlers and tests

Preserve any module and test util changes

* Update e2e x/community params proposal test to work without upgrade handler

---------

Co-authored-by: Draco <draco@dracoli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nddeluca nddeluca nddeluca left review comments

@rhuairahrighairidh rhuairahrighairidh rhuairahrighairidh approved these changes

@galxy25 galxy25 galxy25 approved these changes

@pirtleshell pirtleshell pirtleshell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drklee3 @nddeluca @rhuairahrighairidh @galxy25 @pirtleshell