Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Add rocksdb compact command #1804

Merged
merged 13 commits into from Jan 19, 2024
Merged

feat(cli): Add rocksdb compact command #1804

merged 13 commits into from Jan 19, 2024

Conversation

drklee3
Copy link
Member

@drklee3 drklee3 commented Jan 4, 2024 •
edited

Description

  • Manual compaction command only enabled with rocksdb

Checklist

  • Changelog has been updated as necessary.

@drklee3 drklee3 marked this pull request as ready for review January 4, 2024 20:21
nddeluca
nddeluca requested changes Jan 4, 2024
View reviewed changes
Copy link
Member

@nddeluca nddeluca left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick review of db opening, optoins, etc. Will wait for changes then review the signal handling -- tho is great you've added that to prevent db corruption

cmd/kava/cmd/rocksdb/compact.go Outdated Show resolved Hide resolved
cmd/kava/cmd/rocksdb/compact.go Outdated Show resolved Hide resolved
cmd/kava/cmd/rocksdb/compact.go Outdated Show resolved Hide resolved
nddeluca
nddeluca requested changes Jan 5, 2024
View reviewed changes
Copy link
Member

@nddeluca nddeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB and compaction logic is great 👍 Just some small touches needed to the signal handling and should be good to merge

cmd/kava/cmd/rocksdb/compact.go Outdated Show resolved Hide resolved
pirtleshell
pirtleshell approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@pirtleshell pirtleshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! worth considering the lift to upstream to cometbft's compact command

approved pending resolution of early exit due to buffered channel @nddeluca mentions

@pirtleshell pirtleshell merged commit 3767030 into master Jan 19, 2024
10 checks passed
@pirtleshell pirtleshell deleted the dl-compact-cmd branch January 19, 2024 18:17
pirtleshell pushed a commit that referenced this pull request Jan 29, 2024
@drklee3 @pirtleshell
feat(cli): Add rocksdb compact command (#1804)
5906a8b 
* Add rocksdb compact command

* Increase compaction log output to 1 min

* Use GetClient/ServerContextFromCmd

* Update cmd info

* Add doc to logColumnFamilyMetadata

* Update RocksDBCmd docs

* Add changelog entry

* Load latest options from rocksdb

* Allow application.db to be compacted

* Rename more store -> db

* Ensure compaction stats output does not run when db is closed

* Add flag for custom stat output interval, return error
pirtleshell pushed a commit that referenced this pull request Mar 4, 2024
@drklee3 @pirtleshell
feat(cli): Add rocksdb compact command (#1804)
c222834 
* Add rocksdb compact command

* Increase compaction log output to 1 min

* Use GetClient/ServerContextFromCmd

* Update cmd info

* Add doc to logColumnFamilyMetadata

* Update RocksDBCmd docs

* Add changelog entry

* Load latest options from rocksdb

* Allow application.db to be compacted

* Rename more store -> db

* Ensure compaction stats output does not run when db is closed

* Add flag for custom stat output interval, return error
pirtleshell pushed a commit that referenced this pull request Apr 5, 2024
@drklee3 @pirtleshell
feat(cli): Add rocksdb compact command (#1804)
455d2bc 
* Add rocksdb compact command

* Increase compaction log output to 1 min

* Use GetClient/ServerContextFromCmd

* Update cmd info

* Add doc to logColumnFamilyMetadata

* Update RocksDBCmd docs

* Add changelog entry

* Load latest options from rocksdb

* Allow application.db to be compacted

* Rename more store -> db

* Ensure compaction stats output does not run when db is closed

* Add flag for custom stat output interval, return error
pirtleshell pushed a commit that referenced this pull request Apr 5, 2024
@drklee3 @pirtleshell
feat(cli): Add rocksdb compact command (#1804)
7880f08 
* Add rocksdb compact command

* Increase compaction log output to 1 min

* Use GetClient/ServerContextFromCmd

* Update cmd info

* Add doc to logColumnFamilyMetadata

* Update RocksDBCmd docs

* Add changelog entry

* Load latest options from rocksdb

* Allow application.db to be compacted

* Rename more store -> db

* Ensure compaction stats output does not run when db is closed

* Add flag for custom stat output interval, return error
pirtleshell pushed a commit that referenced this pull request Apr 5, 2024
@drklee3 @pirtleshell
feat(cli): Add rocksdb compact command (#1804)
f6495a8 
* Add rocksdb compact command

* Increase compaction log output to 1 min

* Use GetClient/ServerContextFromCmd

* Update cmd info

* Add doc to logColumnFamilyMetadata

* Update RocksDBCmd docs

* Add changelog entry

* Load latest options from rocksdb

* Allow application.db to be compacted

* Rename more store -> db

* Ensure compaction stats output does not run when db is closed

* Add flag for custom stat output interval, return error
pirtleshell pushed a commit that referenced this pull request Apr 5, 2024
@drklee3 @pirtleshell
feat(cli): Add rocksdb compact command (#1804)
239b5a2 
* Add rocksdb compact command

* Increase compaction log output to 1 min

* Use GetClient/ServerContextFromCmd

* Update cmd info

* Add doc to logColumnFamilyMetadata

* Update RocksDBCmd docs

* Add changelog entry

* Load latest options from rocksdb

* Allow application.db to be compacted

* Rename more store -> db

* Ensure compaction stats output does not run when db is closed

* Add flag for custom stat output interval, return error
pirtleshell pushed a commit that referenced this pull request Apr 5, 2024
@drklee3 @pirtleshell
feat(cli): Add rocksdb compact command (#1804)
4f86ef9 
* Add rocksdb compact command

* Increase compaction log output to 1 min

* Use GetClient/ServerContextFromCmd

* Update cmd info

* Add doc to logColumnFamilyMetadata

* Update RocksDBCmd docs

* Add changelog entry

* Load latest options from rocksdb

* Allow application.db to be compacted

* Rename more store -> db

* Ensure compaction stats output does not run when db is closed

* Add flag for custom stat output interval, return error
pirtleshell pushed a commit that referenced this pull request Apr 5, 2024
@drklee3 @pirtleshell
feat(cli): Add rocksdb compact command (#1804)
2e3c399 
* Add rocksdb compact command

* Increase compaction log output to 1 min

* Use GetClient/ServerContextFromCmd

* Update cmd info

* Add doc to logColumnFamilyMetadata

* Update RocksDBCmd docs

* Add changelog entry

* Load latest options from rocksdb

* Allow application.db to be compacted

* Rename more store -> db

* Ensure compaction stats output does not run when db is closed

* Add flag for custom stat output interval, return error
pirtleshell pushed a commit that referenced this pull request Apr 5, 2024
@drklee3 @pirtleshell
feat(cli): Add rocksdb compact command (#1804)
9177583 
* Add rocksdb compact command

* Increase compaction log output to 1 min

* Use GetClient/ServerContextFromCmd

* Update cmd info

* Add doc to logColumnFamilyMetadata

* Update RocksDBCmd docs

* Add changelog entry

* Load latest options from rocksdb

* Allow application.db to be compacted

* Rename more store -> db

* Ensure compaction stats output does not run when db is closed

* Add flag for custom stat output interval, return error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nddeluca nddeluca nddeluca requested changes

@galxy25 galxy25 galxy25 approved these changes

@pirtleshell pirtleshell pirtleshell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drklee3 @nddeluca @galxy25 @pirtleshell